-
Notifications
You must be signed in to change notification settings - Fork 219
Conversation
The release ZIP for this PR is accessible via:
Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
Size Change: 0 B Total Size: 1.1 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hsingyuc LGTM. I see the order_number
field in the checkout response and didn't notice any issues when smoke testing. Let's also get a review from Rubik
@ralucaStan Hi Raluca! I'm not sure how you assign reviewers on Rubik team, so I pin you here and let you assign the reviewer for this PR. Thank you for your help! |
Hey @hsingyuc, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻 LGTM Re-ran test suite—let's make sure its green before merge.
The issue is the sequential order number plugin is not compatible with WooPay. Because we don't pass the order number in the checkout endpoint so WooPay can only use the order id as the order number.
Testing
Changelog