Address Ruby 3 RuboCop violations #21541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mokagio
force-pushed
the
mokagio/remove-google-sdk
branch
from
53004bb
to
523b3f2
Compare
mokagio
force-pushed
the
mokagio/rubocop-3-violations
branch
from
180a4f8
to
1c8ffba
Compare
|
| App Name |  WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr21541-57473ab | |
| Version | 23.2 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 57473ab | |
| App Center Build | WPiOS - One-Offs #7090 |
|
| App Name |  Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr21541-57473ab | |
| Version | 23.2 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 57473ab | |
| App Center Build | jetpack-installable-builds #6133 |
crazytonyli
approved these changes
Sep 11, 2023
mokagio
force-pushed
the
mokagio/remove-google-sdk
branch
from
8941b1b
to
1748d8e
Compare
17ec957 (#21498) switched the expected Ruby version to 3.x (🎉) Our Ruby linting automation only runs on diffed files so it didn't catch new violations that arose from the migration. The only reason I noticed, actually was because I just happened to modify the `Podfile` in 8df0aa0 (#21344) and got a CI failure.
mokagio
force-pushed
the
mokagio/rubocop-3-violations
branch
from
1c8ffba
to
57473ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
17ec957 (#21498) switched the expected Ruby version to 3.x (🎉)
Our Ruby linting automation only runs on diffed files so it didn't catch new violations that arose from the migration. The only reason I noticed, actually was because I just happened to modify the
Podfilein df0aa0bd25a3cf4fa6313eb3534bd05c959a2a8 (#21344) and got a CI failure. I based this PR off #21344 because I had to fix one of the issues there in order for the linter to pass.To test: checkout the branch and verify RuboCop doesn't find new violations:
Regression Notes
PR submission checklist:
RELEASE-NOTES.txtif necessary. N.A.UI changes testing checklist: Not a UI PR.