Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add setupFilesAfterEnv to Jest configuration #4545

Merged
merged 3 commits into from
Feb 4, 2022
Merged

Add setupFilesAfterEnv to Jest configuration #4545

merged 3 commits into from
Feb 4, 2022

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Feb 3, 2022 •
edited
Loading

Following the Jest configuration in Gutenberg, this PR adds the reference to the setup-after-env.js file, which allows us to use the custom matcher toBeVisible.

Additionally, the editor rendering test has been updated to use the custom matcher toBeVisible.

To test:

  • Run the command npm run test and observe that all tests pass.
  • Check that all PR checks pass.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@fluiddot fluiddot added the Testing Anything related to automated tests label Feb 3, 2022
@fluiddot fluiddot self-assigned this Feb 3, 2022
@peril-wordpress-mobile
Copy link

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

dcalhoun
dcalhoun approved these changes Feb 4, 2022
View reviewed changes
Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks good!

@fluiddot fluiddot added this to the 1.72.0 milestone Feb 4, 2022
@fluiddot fluiddot merged commit f2ff0ff into develop Feb 4, 2022
@fluiddot fluiddot deleted the add/jest-setup-files-after-env branch February 4, 2022 09:25
@hypest hypest mentioned this pull request Feb 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcalhoun dcalhoun dcalhoun approved these changes

Assignees

@fluiddot fluiddot

Labels
Testing Anything related to automated tests
Projects
None yet
Milestone
1.72.0 (19.5)
Development

Successfully merging this pull request may close these issues.
2 participants
@fluiddot @dcalhoun