Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration tests to cover replace functionality of VideoPress block #5825

Merged
merged 8 commits into from
Jun 5, 2023
Merged

Add integration tests to cover replace functionality of VideoPress block #5825

merged 8 commits into from
Jun 5, 2023

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Jun 1, 2023 •
edited
Loading

Related to #5734.

To test:

  1. Run the command: npm run test and observe that all tests pass.
  2. Check that all CI jobs succeed.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@fluiddot fluiddot added Testing Anything related to automated tests VideoPress block labels Jun 1, 2023
@fluiddot fluiddot self-assigned this Jun 1, 2023
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 1, 2023 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@fluiddot fluiddot force-pushed the add/videopress-replace-test-cases branch from edb3906 to afd7698 Compare June 1, 2023 14:33
@fluiddot fluiddot marked this pull request as ready for review June 1, 2023 14:34
@fluiddot fluiddot requested review from jhnstn and SiobhyB June 1, 2023 14:34
@fluiddot fluiddot added this to the 1.97.0 (22.6) milestone Jun 1, 2023
@fluiddot fluiddot mentioned this pull request Jun 1, 2023
Closed
5 tasks
SiobhyB
SiobhyB approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@SiobhyB SiobhyB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for adding these @fluiddot 🙇‍♀️

@fluiddot fluiddot merged commit 73cb0ac into trunk Jun 5, 2023
@fluiddot fluiddot deleted the add/videopress-replace-test-cases branch June 5, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SiobhyB SiobhyB SiobhyB approved these changes

@jhnstn jhnstn Awaiting requested review from jhnstn

Assignees

@fluiddot fluiddot

Labels
Testing Anything related to automated tests VideoPress block
Projects
None yet
Milestone
1.97.0 (22.6)
Development

Successfully merging this pull request may close these issues.
2 participants
@fluiddot @SiobhyB