Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ new(react-pagination): Create package. #121

Merged
merged 15 commits into from
Jun 17, 2021
Merged

✨ new(react-pagination): Create package. #121

merged 15 commits into from
Jun 17, 2021

Conversation

Gowtham369
Copy link
Contributor

@Gowtham369 Gowtham369 commented Jun 9, 2021 •
edited
Loading

This component will let users choose their way of rendering elements and page numbers accordingly.

@Gowtham369 Gowtham369 requested a review from iamleigh June 9, 2021 02:54
@Gowtham369 Gowtham369 assigned Gowtham369 and unassigned iamleigh Jun 9, 2021
@Gowtham369 Gowtham369 added the new Introduce new features label Jun 9, 2021
iamleigh
iamleigh suggested changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@iamleigh iamleigh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, take a look at each comment I left on the files where I point out the proper fixes. Another thing that must be corrected is the PR message that must be properly formatted. Please, read again the contributions doc.

packages/react-pagination/README.md Show resolved Hide resolved
packages/react-pagination/package.json Show resolved Hide resolved
packages/react-pagination/lib/react-pagination.js Outdated Show resolved Hide resolved
packages/react-pagination/docs/react-pagination.stories.js Show resolved Hide resolved
packages/react-pagination/docs/react-pagination.stories.js Show resolved Hide resolved
packages/react-pagination/lib/react-pagination.js Outdated Show resolved Hide resolved
@iamleigh iamleigh marked this pull request as draft June 10, 2021 00:32
@Gowtham369 Gowtham369 marked this pull request as ready for review June 11, 2021 03:58
@Gowtham369 Gowtham369 changed the title New/gowtham pagination 🐛 new(react-pagination): Created a new Pagination component Jun 11, 2021
@Gowtham369 Gowtham369 requested a review from iamleigh June 11, 2021 16:55
@Gowtham369 Gowtham369 marked this pull request as draft June 11, 2021 16:56
@Gowtham369 Gowtham369 marked this pull request as ready for review June 11, 2021 16:58
@iamleigh iamleigh changed the title 🐛 new(react-pagination): Created a new Pagination component ✨ new(react-pagination): Create package. Jun 14, 2021
iamleigh
iamleigh suggested changes Jun 15, 2021
View reviewed changes
packages/react-pagination/lib/react-pagination.js Outdated Show resolved Hide resolved
packages/react-pagination/lib/react-pagination.js Outdated Show resolved Hide resolved
packages/react-pagination/lib/react-pagination.js Outdated Show resolved Hide resolved
@iamleigh iamleigh marked this pull request as draft June 15, 2021 21:23
@Gowtham369 Gowtham369 marked this pull request as ready for review June 17, 2021 05:44
@Gowtham369 Gowtham369 changed the base branch from master to development June 17, 2021 16:23
iamleigh
iamleigh approved these changes Jun 17, 2021
View reviewed changes
Copy link
Contributor

@iamleigh iamleigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR still needs some work but I will approve it and will move anything that's missing to different tasks for improvements and/or bug fixes.

@iamleigh iamleigh merged commit cf6f85e into development Jun 17, 2021
@iamleigh iamleigh deleted the new/gowtham-pagination branch July 31, 2021 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamleigh iamleigh iamleigh approved these changes

Assignees

@Gowtham369 Gowtham369

Labels
new Introduce new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gowtham369 @iamleigh