Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ new(react-modal): Create new component. #92

Merged
merged 49 commits into from
Apr 22, 2021
Merged

✨ new(react-modal): Create new component. #92

merged 49 commits into from
Apr 22, 2021

Conversation

a-danae
Copy link
Contributor

@a-danae a-danae commented Apr 21, 2021

No description provided.

Danae Millan and others added 26 commits March 24, 2021 14:17
Allow adding custom classes and rendering children into Box components
4a91ebe
Allow passing a function to button-icon and adding custom classes
dbf4be6
Add the base for the new 'modal' component
918239f
Remove onclick param for the ButtinIcon component
46e74c2
Make the close button first in the header for better accessibility
884c72c
Allow children to open and close the modal
0126c59
Handle closing animation
9ecc3c5
Render modal's header, footer, and body if the content is provided
cf05979
Revert "Allow adding custom classes and rendering children into Box c…
3646cb9 
…omponents"

This reverts commit 4a91ebe.
Remove extra content for modal story and bind template
13ab454
Simplify the modal component
7d645f5
@iamleigh
🔒️ Update yarn lock file.
c79253e
@iamleigh
📝 docs(react-modal): Improve sample box header.
50627dd
Add the 'slider' functionality to modals
e805863
Add a separate story for the 'slide' modal in docs
801c1cd
@iamleigh
➕ new(react-modal): Add react-box dependency.
6aea12f
@iamleigh
➕ fix(react-modal): Missing react dependency.
c58cdd8
Add a modal with a 'replace' behavior
1d80918
Merge branch 'development' into new/modal
e01c679
Merge branch 'new/modal' into new/modal-replace
31e4e96
Fix merge error
db9351c
Merge branch 'new/modal' into new/modal-replace
f6af38e
Allow replacing modals with the 'modal' component
2dfdc96
Fix first modal not closing when clicking on the 'close' icon
017e9b9
@a-danae
Merge pull request #91 from wpmudev/new/modal-replace
66af225 
New/modal replace
Adjust dependency importing and template
96c1fe5
@a-danae a-danae added the new Introduce new features label Apr 21, 2021
@a-danae a-danae requested a review from iamleigh April 21, 2021 20:12
@a-danae a-danae self-assigned this Apr 21, 2021
@a-danae a-danae changed the base branch from master to development April 21, 2021 20:13
@iamleigh iamleigh changed the title ✨ new(react-modal): Add the new modal component ✨ new(react-modal): Create new modal package. Apr 21, 2021
@iamleigh iamleigh changed the title ✨ new(react-modal): Create new modal package. ✨ new(react-modal): Create new modal component. Apr 21, 2021
iamleigh and others added 23 commits April 21, 2021 15:41
@iamleigh
🚚 fix(react-modal): Rename source file.
1af5eb5
@iamleigh
🚚 fix(react-modal): Rename stories file.
a376d65
@iamleigh
👥 new(react-modal): Add contributor.
33e400d
@iamleigh
📄 new(react-modal): Add license.
be82a8a
@iamleigh
🐛 fix(react-modal): Wrong directory declared.
6bba446
@iamleigh
🐛 fix(react-modal): Initial version for new components must be zero.
918727c
@iamleigh
🐛 fix(react-modal): Package compiler dependency.
48894c5
@iamleigh
🐛 fix(react-modal): Add missing dependencies.
121a2d9
Revert "Allow passing a function to button-icon and adding custom cla…
d1a96ab 
…sses"

This reverts commit dbf4be6.
Revert "Fix merge error"
a1f0431 
This reverts commit db9351c.
Add content to the readme file
4bf1d90
@iamleigh
🐛 fix(react-modal): Improve sample stories.
c06803d
@iamleigh
Merge branch 'new/modal' of github.com:wpmudev/shared-ui-react
a3dd26d
Remove default 'initialFocus' property
4016a30
Allow sliders to have different sizes
a3e4881
Fix console errors
2664891
@iamleigh
🐛 fix(react-modal): Change sample modal size.
db91ec4
@iamleigh
🐛 fix(react-modal): Improve replace story.
9f05498
Update replace sample to close both modals
fd77f51
Revert "Add content to the readme file"
4818648 
This reverts commit 4bf1d90.
Add content to the right readme
9e38a89
Merge branch 'development' into new/modal
34c9bfc
Remove 'extraClasses' from button icons in docs
8abe641
iamleigh
iamleigh approved these changes Apr 22, 2021
View reviewed changes
packages/react-button-icon/lib/react-button-icon.js Outdated Show resolved Hide resolved
packages/react-modal/README.md Outdated Show resolved Hide resolved
@iamleigh iamleigh changed the title ✨ new(react-modal): Create new modal component. ✨ new(react-modal): Create new component. Apr 22, 2021
@iamleigh iamleigh linked an issue Apr 22, 2021 that may be closed by this pull request
[Modal] Create new component. #39
Closed
@iamleigh iamleigh merged commit e9cdb6d into development Apr 22, 2021
@iamleigh iamleigh deleted the new/modal branch April 22, 2021 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamleigh iamleigh iamleigh approved these changes

Assignees

@a-danae a-danae

Labels
new Introduce new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Modal] Create new component.
2 participants
@a-danae @iamleigh