-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default token type of portal apps to JWT. #12281
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tharindu1st
requested changes
Feb 18, 2024
....util/src/main/java/org/wso2/carbon/apimgt/rest/api/util/impl/OAuthJwtAuthenticatorImpl.java
Outdated
Show resolved
Hide resolved
load certificate/jwks url from resident IDP and validate signature against the token.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #12281 +/- ##
============================================
+ Coverage 41.93% 47.35% +5.42%
- Complexity 3255 4112 +857
============================================
Files 1831 1838 +7
Lines 134998 135587 +589
Branches 19493 19586 +93
============================================
+ Hits 56605 64212 +7607
+ Misses 71586 63830 -7756
- Partials 6807 7545 +738
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This was referenced Feb 20, 2024
remove logic to get JWKS endpoint to validate signature.
tharikaGitHub
approved these changes
Feb 22, 2024
tharindu1st
approved these changes
Feb 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing wso2/api-manager#2496
wso2/api-manager#2495