Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default token type of portal apps to JWT. #12281

Merged
merged 8 commits into from
Feb 25, 2024

Conversation

dushaniw
Copy link
Contributor

@dushaniw dushaniw commented Feb 18, 2024

load certificate/jwks url from resident IDP and validate signature against the token.
@dushaniw dushaniw removed the request for review from tharindu1st February 19, 2024 11:27
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 93 lines in your changes are missing coverage. Please review.

Comparison is base (28ffa8f) 41.93% compared to head (0126f51) 47.35%.
Report is 84 commits behind head on master.

Files Patch % Lines
.../rest/api/util/impl/OAuthJwtAuthenticatorImpl.java 0.00% 62 Missing ⚠️
...steners/GatewayTokenRevocationMessageListener.java 0.00% 14 Missing ⚠️
...ava/org/wso2/carbon/apimgt/impl/utils/APIUtil.java 0.00% 10 Missing ⚠️
...rest/api/dcr/web/impl/RegistrationServiceImpl.java 0.00% 5 Missing and 1 partial ⚠️
...2/carbon/apimgt/impl/factory/KeyManagerHolder.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12281      +/-   ##
============================================
+ Coverage     41.93%   47.35%   +5.42%     
- Complexity     3255     4112     +857     
============================================
  Files          1831     1838       +7     
  Lines        134998   135587     +589     
  Branches      19493    19586      +93     
============================================
+ Hits          56605    64212    +7607     
+ Misses        71586    63830    -7756     
- Partials       6807     7545     +738     
Flag Coverage Δ
integration_tests 41.98% <0.00%> (+6.79%) ⬆️
unit_tests 20.56% <0.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dushaniw dushaniw merged commit 12698ca into wso2:master Feb 25, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants