Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs related to integration of Harshicrop Vault extension #8432

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add docs related to integration of Harshicrop Vault extension #8432

wants to merge 2 commits into from
+283 −0

Conversation

BiyonFernando
Copy link
Contributor

Purpose

This PR will introduce documentation for integrate APIM with harshicrop vault extension [1].

[1] - https://github.com/wso2-extensions/carbon-securevault-hashicorp/tree/master

tharikaGitHub
tharikaGitHub reviewed Oct 2, 2024
View reviewed changes
en/docs/install-and-setup/setup/security/logins-and-passwords/harshicrop-vault-extension.md Outdated

1. Clone [HashiCorp Vault extension](https://github.com/wso2-extensions/carbon-securevault-hashicorp/tree/master) repo

2. Build the HashiCorp Vault Integration OSGI bundle using `mvn clean install` and copy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
2. Build the HashiCorp Vault Integration OSGI bundle using `mvn clean install` and copy
2. Build the HashiCorp Vault Integration OSGI bundle using `mvn clean install` command and copy

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrected in 1d8bdff

tharikaGitHub
tharikaGitHub reviewed Oct 2, 2024
View reviewed changes
en/docs/install-and-setup/setup/security/logins-and-passwords/harshicrop-vault-extension.md

=== "Linux"
```
The file name should be `hashicorpRootToken-persist`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change the formatting as suitable for a statement.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrected in 1d8bdff

tharikaGitHub
tharikaGitHub reviewed Oct 2, 2024
View reviewed changes
en/docs/install-and-setup/setup/security/logins-and-passwords/harshicrop-vault-extension.md Outdated
[Enter KeyStore and Private Key Password :] wso2carbon
```

---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
---

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrected in 1d8bdff

tharikaGitHub
tharikaGitHub previously approved these changes Oct 3, 2024
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tharikaGitHub tharikaGitHub tharikaGitHub left review comments

@Arshardh Arshardh Awaiting requested review from Arshardh

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BiyonFernando @tharikaGitHub