Merge pull request #3556 from sajinieKavindya/newest-master

Removing JMS polling consumer reference from JMS task to avoid dangling consumers in broker side
wso2 · Sep 11, 2024 · 11bb8b0 · 11bb8b0
2 parents 74ddade + 6820d7b
commit 11bb8b0
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/...inbound.endpoint/src/main/java/org/wso2/carbon/inbound/endpoint/protocol/jms/JMSTask.java b/...inbound.endpoint/src/main/java/org/wso2/carbon/inbound/endpoint/protocol/jms/JMSTask.java
@@ -43,7 +43,11 @@ public JMSTask(JMSPollingConsumer jmsPollingConsumer, long interval) {
 
     protected void taskExecute() {
         logger.debug("Executing JMS Task Execution.");
-        jmsPollingConsumer.execute();
+        if (jmsPollingConsumer != null) {
+            jmsPollingConsumer.execute();
+        } else {
+            logger.error("JMS Polling Consumer is closed. Cannot execute the task.");
+        }
     }
 
     @Override
@@ -58,6 +62,8 @@ public void init(SynapseEnvironment synapseEnvironment) {
     public void destroy() {
         logger.debug("Destroying JMS Task.");
         jmsPollingConsumer.destroy();
+        // removing the consumer reference to avoid dangling consumers in broker side.
+        jmsPollingConsumer = null;
     }
 
     /**