Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added test case to validate both basic auth and auth2 enable api through basic auth. #13179

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added test case to validate both basic auth and auth2 enable api through basic auth. #13179

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1711534
Added test case to validate both basic auth and auth2 enable api thro…
prasa7 Mar 10, 2023
ac400b6
Added suggested fixes in PR>
prasa7 Mar 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions ...ackend/src/test/java/org/wso2/am/integration/tests/api/lifecycle/APISecurityTestCase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,9 @@ public class APISecurityTestCase extends APIManagerLifecycleBaseTest {
private final String OauthEnabledAPIContext = "OauthEnabledAPI";
private final String apiKeySecuredAPIContext = "apiKeySecuredAPI";
private final String basicAuthSecuredAPI = "BasicAuthSecuredAPI";
private final String basicAuthAndOauth2SecuredAPI = "BasicAuthAndOauth2SecuredAPI";
private final String basicAuthSecuredAPIContext = "BasicAuthSecuredAPI";
private final String basicAuthAndOauth2SecuredAPI = "BasicAuthAndOauth2SecuredAPI";
private final String API_END_POINT_METHOD = "/customers/123";
private final String API_VERSION_1_0_0 = "1.0.0";
private final String APPLICATION_NAME = "AccessibilityOfDeprecatedOldAPIAndPublishedCopyAPITestCase";
Expand All @@ -119,6 +121,7 @@ public class APISecurityTestCase extends APIManagerLifecycleBaseTest {
private String apiId5;
private String apiId6;
private String apiId7;
private String apiId8;
private SubscriptionDTO subscriptionDTO;
private final String API_RESPONSE_DATA = "<id>123</id><name>John</name></Customer>";
String users[] = {"apisecUser", "apisecUser2@wso2.com", "apisecUser2@abc.com"};
Expand Down Expand Up @@ -353,6 +356,33 @@ public void initialize()

HttpResponse response7 = restAPIPublisher.addAPI(apiRequest7);
apiId7 = response7.getData();

APIRequest apiRequest8 = new APIRequest(basicAuthAndOauth2SecuredAPI, basicAuthAndOauth2SecuredAPI,
new URL(apiEndPointUrl));
apiRequest8.setVersion(API_VERSION_1_0_0);
apiRequest8.setTiersCollection(APIMIntegrationConstants.API_TIER.UNLIMITED);
apiRequest8.setTier(APIMIntegrationConstants.API_TIER.UNLIMITED);
apiRequest8.setTags(API_TAGS);
apiRequest8.setVisibility(APIDTO.VisibilityEnum.PUBLIC.getValue());
apiRequest8.setOperationsDTOS(operationsDTOS);
apiRequest8.setProvider(user.getUserName());

List<String> securitySchemes8 = new ArrayList<>();
securitySchemes8.add("basic_auth");
securitySchemes8.add("oauth_basic_auth_api_key_mandatory");
securitySchemes8.add("oauth2");
apiRequest8.setSecurityScheme(securitySchemes5);
apiRequest8.setDefault_version("true");
apiRequest8.setHttps_checked("https");
apiRequest8.setHttp_checked(null);
HttpResponse response8 = restAPIPublisher.addAPI(apiRequest8);
apiId8 = response8.getData();
createAPIRevisionAndDeployUsingRest(apiId8, restAPIPublisher);
restAPIPublisher.changeAPILifeCycleStatusToPublish(apiId8, false);
waitForAPIDeploymentSync(apiRequest5.getProvider(), apiRequest5.getName(), apiRequest5.getVersion(),
APIMIntegrationConstants.IS_API_EXISTS);


}

@Test(description = "This test case tests the behaviour of internal Key token on Created API with authentication " +
Expand Down Expand Up @@ -1199,6 +1229,16 @@ public void testInvocationWithApiKeysWithoutSubscription() throws Exception {
", but got " + invocationResponseAfterSubscriptionRemoved.getResponseCode());
}

@Test(description = "Testing the invocation with Basic Auth for APIKey Only API", dependsOnMethods = {
"testInvokeBasicAuthAfterCredentialsInvalid"})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the test description

public void testInvocationWithBasicAuthandOauth2ForAPIKey() throws Exception {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test method name not conveying what is tested

Map<String, String> requestHeaders = new HashMap<>();
requestHeaders.put("accept", "text/xml");
requestHeaders.put("Authorization", "Basic abcce");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Header value should be set correctly

HttpResponse response = HTTPSClientUtils.doGet(getAPIInvocationURLHttps(basicAuthSecuredAPIContext,
API_VERSION_1_0_0) + API_END_POINT_METHOD, requestHeaders);
Assert.assertEquals(response.getResponseCode(), HttpStatus.SC_OK);
}
@AfterClass(alwaysRun = true)
public void cleanUpArtifacts() throws Exception {
restAPIStore.deleteApplication(applicationId);
Expand All @@ -1209,6 +1249,7 @@ public void cleanUpArtifacts() throws Exception {
restAPIPublisher.deleteAPI(apiId5);
restAPIPublisher.deleteAPI(apiId6);
restAPIPublisher.deleteAPI(apiId7);
restAPIPublisher.deleteAPI(apiId8);
removeUsers();
}

Expand Down