-
Notifications
You must be signed in to change notification settings - Fork 96
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: use raw_value instead of arbitrary_precision
The `arbitrary_precision` feature from `serde_json` is used mostly because of how the Cairo 0 artifact represents big numbers in raw number format instead of string. Without this feature enabled the correct class hash could not be obtained. However, the implementation of this feature is problematic and has been causing issues. Switching to `raw_value` wouldn't resolve those as `raw_value` suffers from the very same issues as `arbitrary_precision`. What's less bad about `raw_value` is that using it is opt-in - it doesn't pollute number decoding like `arbitrary_precision` does. This is important due to how Cargo resolves dependencies - dependants of this library might be forced to enable the `serde_json` feature.
- Loading branch information
1 parent
d5f6e8d
commit a14b825
Showing
5 changed files
with
6 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters