-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
starknet-core
dependency serde_json
arbitrary precision feature flag
#394
Comments
This is a problem and the feature itself has caused issues but it's not true that the feature is not used. Specifically Cairo 0 contract artifacts require this to function. Can you show me a minimal example where this is happening though? I've never encountered this specific issue myself. Thanks! |
I created a repro repo here. The issue only appears when serializing data with libraries that are not |
Another option is to put the cairo0 stuff behind a feature flag and only set the arbitrary precision flag in that case. |
Thanks! Really appreciate this. |
The starknet-core crate has the
serde_json
arbitrary precision feature flag enabled.This flag causes numbers to be encoded as the following object:
Any library that depends on
starknet-core
will then use this encoding for numbers.Since AFAIK the crate is not using this specific feature I believe it makes sense to drop the feature flag.
The text was updated successfully, but these errors were encountered: