feat: use raw_value instead of arbitrary_precision #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `arbitrary_precision` feature from `serde_json` is used mostly because of how the Cairo 0 artifact represents big numbers in raw number format instead of string. Without this feature enabled the correct class hash could not be obtained. However, the implementation of this feature is problematic and has been causing issues. Switching to `raw_value` wouldn't resolve those as `raw_value` suffers from the very same issues as `arbitrary_precision`. What's less bad about `raw_value` is that using it is opt-in - it doesn't pollute number decoding like `arbitrary_precision` does. This is important due to how Cargo resolves dependencies - dependants of this library might be forced to enable the `serde_json` feature.
xJonathanLEI
force-pushed
the
dev/no_arbitrary_precision
branch
from
bb0fcde
to
a14b825
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
arbitrary_precisionfeature fromserde_jsonis used mostly because of how the Cairo 0 artifact represents big numbers in raw number format instead of string. Without this feature enabled the correct class hash could not be obtained.However, the implementation of this feature is problematic and has been causing issues. Switching to
raw_valuewouldn't resolve those asraw_valuesuffers from the very same issues asarbitrary_precision. What's less bad aboutraw_valueis that using it is opt-in - it doesn't pollute number decoding likearbitrary_precisiondoes. This is important due to how Cargo resolves dependencies - dependants of this library might be forced to enable theserde_jsonfeature.Resolves #394.