Countdown Timer: Some small fixes and improvements #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For timer expiry, replaces use of the builtin `sequence_audiovisual_alert` notification sequence wiith a custom alarm modeled after that of a typical electronic kitchen timer. (A repeating one second sequence of four short beeps) Note this currently omits the sound and vibration setting overrides that feature in the builtin sequence, so the alarm will now follow the user's sound and vibration settings.
`expected_count` is set to be a minimum of 1 to avoid dividing by zero at the bottom of the affected function. The progress bar at the top now renders as empty when the time is set to zero.
When pressing right, adds the modulo number to the `selection` variable before subtracting and modulo'ing it. This prevents it from being assigned a negative value (which cannot be relied upon for an enum), as well as making the variable properly wrap around below "zero". While not strictly necessary, the code for handling left button presses is also changed for consistency.
|
Hey there. The improved codes have applied to my repo. Thank you. |
|
Thanks! |
|
@0w0mewo Coincidentally, this was one of the apps I was using to familiarize myself with Flipper's API for writing a somewhat related app of my own. I've personally found the Flipper to be a great device for mundane little utility apps without having all the complexity of a phone, so having a timer app available has been a great addition for my purposes. Thank you as well :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order of commit:
Further details can be found in the description for each commit