Skip to content

Commit

Permalink
[binderator] Tweaks to update-config console output. (#945)
Browse files Browse the repository at this point in the history
Make 2 tweaks to the `update-config` console output.  Note these do not affect anything that is written to `config.json`, just what is written to the console.

- Add number of packages and dependencies to table header:

```console
| 340 Packages (* = Has Update)                              | Currently Bound   | Latest Stable   |
|------------------------------------------------------------|-------------------|-----------------|
| androidx.activity.activity                                 | 1.9.1             | 1.9.1           |
...

| 18 Dependencies (* = Has Update)                           | Current Reference | Latest Publish  |
|------------------------------------------------------------|-------------------|-----------------|
| Xamarin.GooglePlayServices.Ads.Identifier                  | 118.1.0.1         | 118.1.0.1       |
...
```

- Show if there are updates available for "Frozen" packages.  Previously it would just show as frozen and not show if there were updates available.

```console
// Previous behavior
| # com.google.android.material.material                     | 1.11.0            | 1.11.0          |

// New behavior
| #* com.google.android.material.material                    | 1.11.0            | 1.12.0          |
```
  • Loading branch information
jpobst committed Aug 23, 2024
1 parent a959474 commit d8ae981
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ static async Task RunUpdateCommand (string configFile, string [] dependencyFiles
OutputDependencyTable (config);

// Write updated values back to original locations so they get serialized
foreach (var a in config.MavenArtifacts) {
foreach (var a in config.MavenArtifacts.Where (a => !a.Frozen)) {
a.Version = a.LatestVersion;
a.NugetVersion = a.LatestNuGetVersion;
}
Expand All @@ -48,36 +48,40 @@ static async Task RunUpdateCommand (string configFile, string [] dependencyFiles

static void OutputArtifactTable (BindingConfig config)
{
var column1 = "Package (* = Has Update)".PadRight (58);
var bound_artifacts = config.MavenArtifacts.Where (a => !a.DependencyOnly);

var column1 = $"{bound_artifacts.Count ()} Packages (* = Has Update)".PadRight (58);
var column2 = "Currently Bound".PadRight (17);
var column3 = "Latest Stable".PadRight (15);

Console.WriteLine ($"| {column1} | {column2} | {column3} |");
Console.WriteLine ("|------------------------------------------------------------|-------------------|-----------------|");

foreach (var art in config.MavenArtifacts.Where (a => !a.DependencyOnly)) {
foreach (var art in bound_artifacts) {
var package_name = $"{art.GroupId}.{art.ArtifactId}";

if (art.NewVersionAvailable)
package_name = "* " + package_name;

if (art.Frozen)
package_name = "# " + package_name;
package_name = (package_name.StartsWith ('*') ? "#" : "# ") + package_name;

Console.WriteLine ($"| {package_name.PadRight (58)} | {art.Version.PadRight (17)} | {art.LatestVersion.PadRight (15)} |");
}
}

static void OutputDependencyTable (BindingConfig config)
{
var column1 = "Dependencies (* = Has Update)".PadRight (58);
var dependency_artifacts = config.MavenArtifacts.Where (a => a.DependencyOnly);

var column1 = $"{dependency_artifacts.Count ()} Dependencies (* = Has Update)".PadRight (58);
var column2 = "Current Reference".PadRight (17);
var column3 = "Latest Publish".PadRight (15);

Console.WriteLine ($"| {column1} | {column2} | {column3} |");
Console.WriteLine ("|------------------------------------------------------------|-------------------|-----------------|");

foreach (var art in config.MavenArtifacts.Where (a => a.DependencyOnly)) {
foreach (var art in dependency_artifacts) {
var package_name = art.NugetPackageId ?? $"{art.GroupId}.{art.ArtifactId}";

if (art.NewNuGetVersionAvailable)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,6 @@ public static async Task Update (BindingConfig config, List<string> dependencyCo

static bool HasUpdate (MavenArtifactConfig model, Artifact artifact)
{
// Don't update package if it's "Frozen"
if (model.Frozen)
return false;

// Get latest stable version
var latest = GetLatestVersion (artifact);

Expand Down

0 comments on commit d8ae981

Please sign in to comment.