Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual updates 20230329 androidx.media.players #779

Merged
merged 158 commits into from
Jul 30, 2024

Conversation

moljac
Copy link
Member

@moljac moljac commented Aug 28, 2023

Context:

New APIs for Media players. Needed by some MAUI components.

CommunityToolkit/Maui#1511

Does this change existing APIs?

Not existing., but yes - adds new APIs (packages bound)

Used metadata from #858

  • androidx.media3.*

Describe your contribution

New packages + dependencies

  • androidx.media3:media3-cast - -> 1.0.2
  • androidx.media3:media3-common - -> 1.0.2
  • androidx.media3:media3-database - -> 1.0.2
  • androidx.media3:media3-datasource - -> 1.0.2
  • androidx.media3:media3-datasource-cronet - -> 1.0.2
  • androidx.media3:media3-datasource-rtmp - -> 1.0.2
  • androidx.media3:media3-decoder - -> 1.0.2
  • androidx.media3:media3-effect - -> 1.0.2
  • androidx.media3:media3-exoplayer - -> 1.0.2
  • androidx.media3:media3-exoplayer-dash - -> 1.0.2
  • androidx.media3:media3-exoplayer-hls - -> 1.0.2
  • androidx.media3:media3-exoplayer-rtsp - -> 1.0.2
  • androidx.media3:media3-exoplayer-smoothstreaming - -> 1.0.2
  • androidx.media3:media3-exoplayer-workmanager - -> 1.0.2
  • androidx.media3:media3-extractor - -> 1.0.2
  • androidx.media3:media3-session - -> 1.0.2
  • androidx.media3:media3-transformer - -> 1.0.2
  • androidx.media3:media3-ui - -> 1.0.2
  • androidx.media3:media3-uileanback - -> 1.0.2
  • io.antmedia:rtmpclient - -> 3.2.0
    - com.google.android.gms:playservices-adsidentifier - -> 18.0.1
  • com.google.android.gms:playservices-appset - -> 16.0.2
  • com.google.android.gms:playservices-base - -> 18.1.0
  • com.google.android.gms:playservices-castframework - -> 21.2.0
  • com.google.android.gms:playservices-cronet - -> 18.0.1

@moljac moljac self-assigned this Aug 28, 2023
@moljac moljac marked this pull request as draft August 28, 2023 09:53
@moljac moljac force-pushed the mu-20230329-androidx.media.players branch from 7d5eaa8 to 3c7af9a Compare October 1, 2023 09:40
@moljac
Copy link
Member Author

moljac commented Jul 8, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@jpobst jpobst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look like any of the previous review comments have been addressed, like removing media2 metadata, fixing namespace capitalization, changing the AntMedia project/license to not be for "Tink", etc.

config.json Outdated
@@ -1344,27 +1344,155 @@
"dependencyOnly": false
},
{
"groupId": "androidx.media2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably keep the media2 packages that we are already shipping, as we don't have a way to mark them as deprecated. We might be responsible for shipping a security update to them or something in the future.

@jpobst jpobst mentioned this pull request Jul 29, 2024
@moljac moljac merged commit 08ee35f into main Jul 30, 2024
5 checks passed
@moljac moljac deleted the mu-20230329-androidx.media.players branch July 30, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bind "androidx.media3"
4 participants