[Foundation] Update to xcode9 beta 1 #2235

timrisi · 2017-06-20T23:57:25Z

No description provided.

monojenkins · 2017-06-21T01:13:00Z

Build failure

spouliot · 2017-06-21T01:25:37Z

src/Foundation/Enum.cs

@@ -722,7 +722,8 @@ public enum NSJsonReadingOptions : nuint_compat_int {
 	[Flags]
 	[Native]
 	public enum NSJsonWritingOptions : nuint_compat_int {
-		PrettyPrinted = 1
+		PrettyPrinted = 1,
+		SortedKeys = (1 << 1)


Add a comma on the last entry, it's valid in c# and makes diffs smaller

spouliot · 2017-06-21T01:26:27Z

src/Foundation/Enum.cs

+		All = 0,
+		Team = 1,
+		Group = 2,
+		OwnProcess = 3


Same (and others)

spouliot · 2017-06-21T01:26:50Z

src/Foundation/Enum.cs

+	}
+
+	[Native]
+	public enum NSLinguisticTaggerUnit : nint {


Missing availability attributes

spouliot · 2017-06-21T01:27:33Z

src/foundation.cs

+		[Field ("NSMetadataItemKeywordsKey")]
+		NSString ItemKeywordsKey { get; }
+
+		// extern NSString *const _Nonnull NSMetadataItemTitleKey __attribute__((availability(tvos, unavailable))) __attribute__((availability(watchos, unavailable))) __attribute__((availability(ios, unavailable))) __attribute__((availability(macos, introduced=10.9)));


Remove all comments from sharpie

spouliot · 2017-06-21T01:29:32Z

src/foundation.cs

+		// extern NSString *const _Nonnull NSMetadataItemISOSpeedKey __attribute__((availability(tvos, unavailable))) __attribute__((availability(watchos, unavailable))) __attribute__((availability(ios, unavailable))) __attribute__((availability(macos, introduced=10.9)));
+		[NoWatch, NoTV, NoiOS, Mac (10, 9)]
+		[Field ("NSMetadataItemISOSpeedKey")]
+		NSString ItemISOSpeedKey { get; }


Iso not ISO - only 2 letters acronyms are uppercase in .net

spouliot · 2017-06-21T01:46:34Z

src/foundation.cs

+		[Export ("finished")]
+		bool Finished { [Bind ("isFinished")] get; }[Watch (4, 0), TV (11, 0), Mac (10, 13), iOS (11, 0)]
+		[NullAllowed, Export ("estimatedTimeRemaining", ArgumentSemantic.Copy)]
+		NSNumber EstimatedTimeRemaining { get; set; }


Look at using bindas attribute
Ask @dalexsoto if you have questions

spouliot · 2017-06-21T01:46:42Z

src/foundation.cs

+
+		[Watch (4, 0), TV (11, 0), Mac (10, 13), iOS (11, 0)]
+		[NullAllowed, Export ("throughput", ArgumentSemantic.Copy)]
+		NSNumber Throughput { get; set; }


spouliot · 2017-06-21T01:46:56Z

src/foundation.cs

+
+		[Watch (4, 0), TV (11, 0), Mac (10, 13), iOS (11, 0)]
+		[NullAllowed, Export ("fileTotalCount", ArgumentSemantic.Copy)]
+		NSNumber FileTotalCount { get; set; }


spouliot · 2017-06-21T01:47:03Z

src/foundation.cs

+
+		[Watch (4, 0), TV (11, 0), Mac (10, 13), iOS (11, 0)]
+		[NullAllowed, Export ("fileCompletedCount", ArgumentSemantic.Copy)]
+		NSNumber FileCompletedCount { get; set; }


spouliot · 2017-06-21T01:49:12Z

src/foundation.cs

+
+	[NoWatch, NoTV, Mac (10,13), iOS (11,0)]
+	[BaseType (typeof(NSObject))]
+	interface NSFileProviderMessenger


There's probably no default init if there's a designated initializer

rolfbjarne · 2017-06-21T09:41:43Z

src/foundation.cs

 	}

+	delegate void LinguisticTaggerEnumerateTagsBlock (string tag, NSRange tokenRange, bool stop);


Block sounds strange in C#, maybe use Callback, or something even more different, like LinguisticTagEnumerator.

rolfbjarne · 2017-06-21T09:46:29Z

src/foundation.cs

+	[BaseType (typeof(NSObject))]
+	interface NSItemProviderWriting
+	{
+		//TODO: Where to implement this?


Please file a bug about this so that we don't forget (and add the bug # in the comment).

There's a card for it on the trello board (https://trello.com/c/snhPxWy2/21-static-properties-inside-protocols), do you want a separate bug as well? Not 100% sure if it's a bug or if there's a way to do it that I'm not aware of

rolfbjarne · 2017-06-21T09:48:19Z

src/generator.cs

@@ -3850,6 +3850,8 @@ void GenerateTypeLowering (MethodInfo mi, bool null_allowed_override, EnumMode e
 				by_ref_processing.AppendLine();
 				if (mai.Type.GetElementType () == TypeManager.System_String){
 					by_ref_processing.AppendFormat("{0} = {0}Value != IntPtr.Zero ? NSString.FromHandle ({0}Value) : null;", pi.Name.GetSafeParamName ());
+				} else if ((pi.ParameterType.GetElementType ().IsArray)) {


There are redundant parenthesis around the property access.

rolfbjarne · 2017-06-21T10:05:36Z

@timrisi You duplicated some work Miguel already did in PR #2190 😒 IMHO the best would be to remove everything he implemented from your PR, since yours still contains a lot of new API.

timrisi · 2017-06-21T19:36:38Z

I can pull those parts out, though I'd have to wait for his to be merged and pull the commit(s) into this PR since there's other places that use the protocol I'd be pulling out.

rolfbjarne · 2017-06-22T08:55:36Z

It can take a while to get that PR in, since we need to sort out how to bind constructors in protocols (https://bugzilla.xamarin.com/show_bug.cgi?id=57650) first.

It still looks like there are useful bits here even if you remove all related code to that PR though.

timrisi · 2017-06-22T16:27:35Z

I'll pull out the NSItemProvider(Reading|Writing) stuff for now and create a trello card so it doesn't get forgotten when we figure out how to implement it all (will need updates after miguel's PR goes in)

monojenkins · 2017-06-22T18:32:18Z

Build failure

monojenkins · 2017-06-24T00:17:32Z

Build failure

migueldeicaza · 2017-06-24T03:01:30Z

src/foundation.cs

+		[NoWatch, NoTV, NoiOS, Mac (10, 9)]
+		[Field ("NSMetadataItemTitleKey")]
+		NSString ItemTitleKey { get; }
+


For each one of these properties that were added, you need to update Foundation/NSMetadataItem.cs which is the strongly typed version of this, and it entails figuring out the data type that is being looked up there.

For example, the documentation for this key is that the value is an NSString, so you would need to add to that class something like:

public NSString Title => return Runtime.GetNSObject<NSString> (GetHandle (NSMetadataQuery.ItemTitleKey))

And this needs to be done for each of these new keys.

timrisi · 2017-06-27T01:44:26Z

Heads up there's more I coming here. Some of the bindings for lost in the shuffle swapping back and forth with doing or fixes on other frameworks (stashed, so it doesn't have to be rebound. I'm fixing up merge conflicts to commit)

monojenkins · 2017-06-27T18:05:44Z

Build failure

monojenkins · 2017-06-27T18:47:04Z

Build failure

rolfbjarne · 2017-06-28T06:16:56Z

src/Foundation/Enum.cs

@@ -1258,4 +1259,51 @@ public enum NSMeasurementFormatterUnitOptions : nuint {
 		TemperatureWithoutUnit = (1 << 2)
 	}

+	[Watch(2, 0), TV(9, 0), Mac(10, 8), iOS(6, 0)]
+	[Native]
+	public enum NSXPCConnectionOptions : nuint


XPC -> Xpc.

Realized this one after I pushed. I have all the Xpcs changed locally for when I push again

rolfbjarne · 2017-06-28T06:17:21Z

src/Foundation/Enum.cs

+	[Native]
+	public enum NSXPCConnectionOptions : nuint
+	{
+		NSXPCConnectionPrivileged = (1 << 12)


in this case the enum member name should not be prefixed with NSXPCConnection anyway

rolfbjarne · 2017-06-28T06:20:06Z

src/foundation.cs

+
+		[Watch (4, 0), TV (11, 0), Mac (10, 13), iOS (11, 0)]
+		[NullAllowed, Export ("fileURL", ArgumentSemantic.Copy)]
+		NSUrl FileURL { get; set; }


URL -> Url.

rolfbjarne · 2017-06-28T06:21:44Z

src/foundation.cs

+		void SetClasses (NSSet<Class> classes, Selector sel, nuint arg, bool ofReply);
+
+		[Export ("classesForSelector:argumentIndex:ofReply:")]
+		NSSet<Class> ClassesForSelector (Selector sel, nuint arg, bool ofReply);


GetClasses

rolfbjarne · 2017-06-28T06:21:53Z

src/foundation.cs

+
+		[Export ("interfaceForSelector:argumentIndex:ofReply:")]
+		[return: NullAllowed]
+		NSXpcInterface InterfaceForSelector (Selector sel, nuint arg, bool ofReply);


GetInterface

…ationBindings

spouliot

We need to add tests for those Xpc API to ensure the proving stuff works correctly. we should not expose (post beta) them unless they are confirmed to work properly.

spouliot · 2017-06-29T15:23:20Z

src/Foundation/Enum.cs

+	[Native]
+	public enum NSXPCConnectionOptions : nuint
+	{
+		NSXPCConnectionPrivileged = (1 << 12)


in this case the enum member name should not be prefixed with NSXPCConnection anyway

spouliot · 2017-06-29T15:23:45Z

src/Foundation/Enum.cs

+	[Watch (4, 0), TV (11, 0), Mac (10, 13), iOS (11, 0)]
+	[Native]
+	public enum NSItemProviderFileOptions : nint {
+		NSItemProviderFileOptionOpenInPlace = 1,


remove NSItemProviderFileOption prefix on name

spouliot · 2017-06-29T15:25:14Z

src/foundation.cs

+
+		[Watch (4,0), TV (11,0), Mac (10,13), iOS (11,0)]
+		[Export ("writeToURL:error:")]
+		bool WriteToUrl (NSUrl url, [NullAllowed] out NSError error);


Write the rest is implied by the parameters

spouliot · 2017-06-29T15:26:41Z

src/foundation.cs

+		[Static]
+		[Export ("arrayWithContentsOfURL:error:")]
+		[return: NullAllowed]
+		NSObject[] FromUrl (NSUrl url, [NullAllowed] out NSError error);


that's an odd case. In general returning an [] make sense, but this is a static method in NSArray so it should return an NSArray not another type.

spouliot · 2017-06-29T15:27:07Z

src/foundation.cs

@@ -1715,7 +1725,11 @@ interface NSDateFormatter {

 		[iOS (8,0), Mac (10,10)]
 		[Export ("setLocalizedDateFormatFromTemplate:")]
-		void SetLocalizedDateFormatFromTemplate (string dateFormatTemplate);		
+		void SetLocalizedDateFormatFromTemplate (string dateFormatTemplate);


SetLocalizedDateFormat, the rest is implied

spouliot · 2017-06-29T15:43:27Z

src/foundation.cs

+
+		[NoWatch, NoTV, Mac (10, 13), iOS (11, 0)]
+		[Export ("observedPresentedItemUbiquityAttributes", ArgumentSemantic.Strong)]
+		NSSet<NSString> ObservedUbiquityAttributes { get; }


spouliot · 2017-06-29T15:47:27Z

src/foundation.cs

+
+		[NoWatch, NoTV, Mac (10,13), iOS (11,0)]
+		[Async, Export ("getFileProviderMessageInterfacesForItemAtURL:completionHandler:")]
+		void GetFileProviderMessageInterfaces (NSUrl url, FileProviderMessageInterfacesCompletionHandler completionHandler);


Does FileProviderMessageInterfacesCompletionHandler exists in ObjC ? (it's not prefixed by NS)

When we have a single parameter or a two parameters with a NSError then we can (when it's not confusing) use Action<T[,V]>. That makes it easier to share delegates in code and reduce metadata (app size).

The reason why we can't do it for longer delegates is because the arguments become unclear. That's not the case here since the method name is clear about what will be given and the NSError itself is self-documenting.

Gotcha. It had been pointed out one one of the other (longer) handlers that we needed the delegate because of the multiple parameters and I made all of 2 parameters (with one as an NSError) into delegates, so there's probably others I can change back as well.

I'll go through ll the delegates and convert any that match back to Action<T, V>

spouliot · 2017-06-29T15:47:47Z

src/foundation.cs

@@ -12435,6 +13368,7 @@ interface NSAffineTransform : NSSecureCoding, NSCopying {
 		CGAffineTransform TransformStruct { get; set; }
 	}

+	[Availability (Deprecated = Platform.Mac_10_13 | Platform.iOS_11_0 | Platform.Watch_2_0 | Platform.TV_11_0, Message = "Use NSXpcConnection instead")]


missing . at end of message

spouliot · 2017-06-29T15:47:59Z

src/foundation.cs

@@ -12538,6 +13472,7 @@ interface NSConnection {
 		NSConnectionDelegate Delegate { get; set; }
 	}

+	[Availability (Deprecated = Platform.Mac_10_13 | Platform.iOS_11_0 | Platform.Watch_2_0 | Platform.TV_11_0, Message = "Use NSXpcConnection instead")]


spouliot · 2017-06-29T15:48:07Z

src/foundation.cs

@@ -12561,6 +13496,7 @@ interface NSConnectionDelegate {
 		bool AllowNewConnection (NSConnection newConnection, NSConnection parentConnection);
 	}

+	[Availability (Deprecated = Platform.Mac_10_13 | Platform.iOS_11_0 | Platform.Watch_2_0 | Platform.TV_11_0, Message = "Use NSXpcConnection instead")]


…ationBindings

monojenkins · 2017-06-29T22:30:50Z

Build failure

monojenkins · 2017-07-24T18:39:02Z

Build failure

…ationBindings

monojenkins · 2017-07-26T01:42:12Z

Build failure

monojenkins · 2017-07-26T08:38:49Z

Build failure

timrisi · 2017-07-26T18:17:41Z

I removed the BindAs attributes and manually bound strongly-typed versions of the properties, so I'm removing the don't-merge tag

monojenkins · 2017-07-26T18:21:39Z

Build success

This fix is needed by PDFKit because it is a remapped framework[0], the current code generates incorrect FieldAttribute on smart enums because it uses `fa.LibraryName` as first option and this causes remmaped frameworks have incorrect LibraryName generated for example if a Field uses `+CoreImage` as `LibraryName` the following incorrect code is generated: ``` [Field ("First", "+CoreImage")] internal unsafe static IntPtr First { get { fixed (IntPtr *storage = &values [0]) return Dlfcn.CachePointer (Libraries.+CoreImage.Handle, "First", storage); } } ``` [0]: https://github.com/xamarin/xamarin-macios/blob/f5956d6cc1eb5dfa7bab16628cf282d40237f64e/src/generator.cs#L5985

…i.cs (#2358)

#2357)

Apple removed (mistake?) some API in beta 1. Filed as rdar 33590997 Internal tracking in https://trello.com/c/J8BDDUV9/86-33590997-coreanimation-quartzcore-api-removals

rolfbjarne · 2017-08-01T16:31:06Z

Make.config

@@ -40,7 +40,7 @@ IOS_PRODUCT=Xamarin.iOS
 IOS_PACKAGE_NAME=Xamarin.iOS
 IOS_PACKAGE_NAME_LOWER=$(shell echo $(IOS_PACKAGE_NAME) | tr "[:upper:]" "[:lower:]")
 # NEVER customize IOS_PACKAGE_VERSION itself, other parts (mtouch, web updater) are using the IOS_PACKAGE_VERSION_* variables
-IOS_PACKAGE_VERSION=10.99.1.$(IOS_COMMIT_DISTANCE)
+IOS_PACKAGE_VERSION=10.99.2.$(IOS_COMMIT_DISTANCE)


This looks wrong, I think you need to merge in the xcode9 branch.

spouliot · 2017-08-01T17:50:38Z

@timrisi there should not be any need to merge in most cases as the PR gets tested on top of the HEAD of the branch.

timrisi · 2017-08-01T17:53:41Z

In this case, I was merging so I could get the PhotosUI commit since it fixes crashes in the introspection tests to make it a lot easier to run the tests locally. Not sure what exactly I did here, this is the first time I've accidentally pulled in other commits when I tried to merge.

monojenkins · 2017-08-01T19:30:40Z

Build failure

spouliot · 2017-08-09T13:55:57Z

@timrisi the PR failed the tests (but was not investigated), it's also not mergeable (fixing this does not require a merge) and it's not clear which beta version is supported.
Please review the failure(s) and update the PR to cover up to beta 5.

timrisi · 2017-08-09T20:44:24Z

Replaced with an updated (and rebased) PR: #2468

Timothy Risi added 3 commits June 20, 2017 15:35

[Foundation] Update for xcode9

ef27775

Rest of the foundation bindings

edbd1f9

Remove a couple CWLs

91336b0

dnfclas added the cla-already-signed label Jun 20, 2017

spouliot suggested changes Jun 21, 2017

View reviewed changes

rolfbjarne requested changes Jun 21, 2017

View reviewed changes

PR fixes

d1afbda

Add bindas attributes

0afb364

migueldeicaza reviewed Jun 27, 2017

View reviewed changes

Timothy Risi added 2 commits June 27, 2017 09:18

Add missing foundation bindings for xcode 9 beta 1

7a894c2

Rename NSXPCFoo to NSXpcFoo

126b501

rolfbjarne requested changes Jun 28, 2017

View reviewed changes

Timothy Risi added 3 commits June 28, 2017 09:04

WIP Foundation bindings

eaf7a74

Merge branch 'xcode9' of github.com:xamarin/xamarin-macios into Found…

a63c745

…ationBindings

Remove duplicate

bc5cd8d

spouliot suggested changes Jun 29, 2017

View reviewed changes

Timothy Risi added 2 commits June 29, 2017 14:14

Update NSMetadataItem.cs for new mac-only keys

56b1509

Merge branch 'xcode9' of github.com:xamarin/xamarin-macios into Found…

f837bfc

…ationBindings

Fix enum name

6b39e0b

Timothy Risi added 2 commits July 25, 2017 10:50

Merge branch 'xcode9' of github.com:xamarin/xamarin-macios into Found…

cf7143d

…ationBindings

Fix Introspection tests

4fffc80

More introspection fixes

e20b4f0

Adde xception to typo test

97c260e

timrisi removed the do-not-merge Do not merge this pull request label Jul 26, 2017

Timothy Risi and others added 12 commits July 31, 2017 12:35

Update to beta 4

5d87388

[arkit] Update for beta 4 (#2370)

bbfdbe1

Bump version before preview 3 (#2375)

c012f23

[FinderSync] Update to beta 4 (#2377)

47ff43e

[ImageIO] Update to Xcode 9 (#2353)

8039c24

[PhotosUI] Move macOS photosui bindings out of photos.cs into photosu…

557d0d0

…i.cs (#2358)

[quicklook] Update up to beta 4 (#2374)

cfdbe98

[uikit] UIDragInteraction & UIDragInteractionDelegate (Xcode 9 b1,2,3) (

513e4b3

#2357)

[safariservices] Update up to beta 4 (#2380)

041fb98

[coreanimation] Update to beta 4 (#2382)

6e54067

Apple removed (mistake?) some API in beta 1. Filed as rdar 33590997 Internal tracking in https://trello.com/c/J8BDDUV9/86-33590997-coreanimation-quartzcore-api-removals

[storekit] Update up to beta 4 (#2379)

944d29d

rolfbjarne requested changes Aug 1, 2017

View reviewed changes

timrisi mentioned this pull request Aug 9, 2017

[Foundation] Update for xcode9 #2468

Merged

timrisi closed this Aug 9, 2017

		}

		delegate void LinguisticTaggerEnumerateTagsBlock (string tag, NSRange tokenRange, bool stop);

[Foundation] Update to xcode9 beta 1 #2235

[Foundation] Update to xcode9 beta 1 #2235

Conversation

timrisi commented Jun 20, 2017

monojenkins commented Jun 21, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

spouliot Jun 21, 2017 • edited by rolfbjarne Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rolfbjarne commented Jun 21, 2017

timrisi commented Jun 21, 2017

rolfbjarne commented Jun 22, 2017

timrisi commented Jun 22, 2017

monojenkins commented Jun 22, 2017

monojenkins commented Jun 24, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

timrisi commented Jun 27, 2017

monojenkins commented Jun 27, 2017

monojenkins commented Jun 27, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

spouliot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

monojenkins commented Jun 29, 2017

monojenkins commented Jul 24, 2017

monojenkins commented Jul 26, 2017

monojenkins commented Jul 26, 2017

timrisi commented Jul 26, 2017

monojenkins commented Jul 26, 2017

Choose a reason for hiding this comment

spouliot commented Aug 1, 2017

timrisi commented Aug 1, 2017

monojenkins commented Aug 1, 2017

spouliot commented Aug 9, 2017

timrisi commented Aug 9, 2017

spouliot Jun 21, 2017 •

edited by rolfbjarne

Loading