[photos] Update up to beta 2 #2290
Conversation
src/Photos/Enums.cs
Outdated
| ImageAnimated = 2, | ||
| LivePhoto = 3, | ||
| Video = 4, | ||
| VideoLooping = 5 |
There was a problem hiding this comment.
Minor: missing comma at the end.
src/photos.cs
Outdated
| [Mac (10,13, onlyOn64 : true)] | ||
| [NoiOS][NoTV] | ||
| [BaseType (typeof (PHAssetCollection))] | ||
| interface PHProject { |
There was a problem hiding this comment.
Minor: Tab instead of space after type name.
| @@ -274,4 +275,52 @@ public enum PHLivePhotoFrameType : nint { | |||
| Photo, | |||
| Video | |||
| } | |||
|
|
|||
| [TV (11,0), iOS (11,0)] | |||
src/photos.cs
Outdated
| @@ -702,11 +722,18 @@ interface PHContentEditingOutput : NSCoding, NSSecureCoding { | |||
|
|
|||
| [Export ("renderedContentURL", ArgumentSemantic.Copy)] | |||
| NSUrl RenderedContentUrl { get; } | |||
|
|
|||
| #if false | |||
There was a problem hiding this comment.
Should we file a bug?? Or add a TODO: here so we do not forget
There was a problem hiding this comment.
upon verification it was added in the wrong type - that's what happen when you're half blind :|
|
Build failure |
|
Build failure |
src/photos.cs
Outdated
| NSData ProjectExtensionData { get; } | ||
|
|
||
| [Field ("PHProjectTypeUndefined")] | ||
| NSString TypeUndefined { get; } |
There was a problem hiding this comment.
Looking at the swift definition for this:
static let undefined: PHProjectType
Where PHProjectType is an NSString typedef. I wonder if this should be in a separate PHProjectType class, to be PHProjectType.Undefined instead of PHProject.TypeUndefined. Seems like something they may add more options to down the line, and could possibly end up as a smart enum
There was a problem hiding this comment.
Good point on the type.
It looks like an extensible name (undefined is unlikely the only valid name) which makes it a bad candidate for a smart enum (even more as it's exposed as a property).
src/photos.cs
Outdated
| interface PHProjectTypeDescription : NSSecureCoding { | ||
|
|
||
| [Export ("projectType")] | ||
| string ProjectType { get; } |
There was a problem hiding this comment.
Wonder if this uses the aforementioned PHProjectTypeUndefined (it also uses the PHProjectType typedef in the header)
src/photos.cs
Outdated
| PHProjectCreationSource CreationSource { get; } | ||
|
|
||
| [Export ("projectType")] | ||
| string ProjectType { get; } |
|
Not seeing any test failures on 10.13 |
…uldRenderAtPlaybackTime (the later needs more work)
src/photos.cs
Outdated
| @@ -1108,10 +1150,22 @@ interface PHLivePhotoEditingContext { | |||
| [Export ("prepareLivePhotoForPlaybackWithTargetSize:options:completionHandler:")] | |||
| void PrepareLivePhotoForPlayback (CGSize targetSize, [NullAllowed] NSDictionary<NSString, NSObject> options, Action<PHLivePhoto, NSError> handler); | |||
|
|
|||
| #if false | |||
There was a problem hiding this comment.
@dalexsoto are we dealt with this case yet ? i.e. creating a strong dict based on the generic nsdictionary
| #if false | ||
| [iOS (10,0)] | ||
| [TV (10,0)] | ||
| #if XAMCORE_2_0 // fails to build with mac/classic |
There was a problem hiding this comment.
@dalexsoto I recall we discussed that a while ago, was a bug filled ? (could not find it)
|
Build failure |
…ad now that b3 provides the required key
|
@timrisi your concerns have been addressed. |
|
Build failure |
|
failure is a known issue -> https://bugzilla.xamarin.com/show_bug.cgi?id=57762 |
No description provided.