Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider JavaScript Geolocation API #133

Open
NotBobTheBuilder opened this issue Dec 31, 2013 · 9 comments
Open

Consider JavaScript Geolocation API #133

NotBobTheBuilder opened this issue Dec 31, 2013 · 9 comments

Comments

@NotBobTheBuilder
Copy link
Collaborator

It would be awesome to have an alternative to the search box which uses window.navigator.geolocation to search for nearby places based on lat/longitude.

Would be particularly useful for mobile users, as it saves typing & gives relevant info. I'll look into it!

@xando
Copy link
Owner

xando commented Dec 31, 2013

I never had anything in common with this API but sounds really useful. I'm really interested.

@NotBobTheBuilder
Copy link
Collaborator Author

There's some pretty good descriptions & examples on mdn

@xando
Copy link
Owner

xando commented Dec 31, 2013

Oh wait, I know this one ;)

I thought that you meant this
https://developers.google.com/maps/documentation/business/geolocation/
though I'm not sure if Google's one is relevant to this case at all.

On Tue, Dec 31, 2013 at 2:48 PM, Jack Wearden notifications@gitpro.ttaallkk.topwrote:

There's some pretty good descriptions & examples on mdnhttps://developer.mozilla.org/en-US/docs/WebAPI/Using_geolocation


Reply to this email directly or view it on GitHubhttps://github.com//issues/133#issuecomment-31395195
.

@NotBobTheBuilder
Copy link
Collaborator Author

Awesome! I reckon the native one would be best - if we're just using the longitude and latitude then the Google one is probably overkill :)

@xando
Copy link
Owner

xando commented Dec 31, 2013

If you know how to put those blocks together, go for it. Mobile is not my
world, won't be interrupting, much.

On Tue, Dec 31, 2013 at 3:09 PM, Jack Wearden notifications@gitpro.ttaallkk.topwrote:

Awesome! I reckon the native one would be best - if we're just using the
longitude and latitude then the Google one is probably overkill :)


Reply to this email directly or view it on GitHubhttps://github.com//issues/133#issuecomment-31395795
.

@NotBobTheBuilder
Copy link
Collaborator Author

I got a really hacky version running in NotBobTheBuilder/commitcoffee@ecac396, but the UX is nasty and the map zooms in too far. Didn't take much work to get going though! I'll tidy it up over the next few days.

@xando
Copy link
Owner

xando commented Dec 31, 2013

No worries, I will look at this some time in the next year ;)

First short comment we, I don't know how mobile handles it but we need to
consider also an use case when user says NO for geolocation.

On Tue, Dec 31, 2013 at 6:15 PM, Jack Wearden notifications@gitpro.ttaallkk.topwrote:

I got a really hacky version running in NotBobTheBuilder/commitcoffee@ecac396NotBobTheBuilder@ecac396,
but the UX is nasty and the map zooms in too far. Didn't take much work to
get going though! I'll tidy it up over the next few days.


Reply to this email directly or view it on GitHubhttps://github.com//issues/133#issuecomment-31402664
.

@jqb
Copy link
Collaborator

jqb commented Dec 31, 2013

Guys please.... - stop do anything right now and get drunk. It's New Year's
Eve :)

On 31 December 2013 18:24, Sebastian Pawluś notifications@gitpro.ttaallkk.topwrote:

No worries, I will look at this some time in the next year ;)

First short comment we, I don't know how mobile handles it but we need to
consider also an use case when user says NO for geolocation.

On Tue, Dec 31, 2013 at 6:15 PM, Jack Wearden notifications@gitpro.ttaallkk.topwrote:

I got a really hacky version running in NotBobTheBuilder/commitcoffee@ecac396<
NotBobTheBuilder@ecac396af5ba8e99b4fa387ab1cb8608b83f643e>,

but the UX is nasty and the map zooms in too far. Didn't take much work
to
get going though! I'll tidy it up over the next few days.


Reply to this email directly or view it on GitHub<
https://github.com/xando/commitcoffee/issues/133#issuecomment-31402664>
.


Reply to this email directly or view it on GitHubhttps://github.com//issues/133#issuecomment-31403029
.

@xando
Copy link
Owner

xando commented Dec 31, 2013

roger that

On Tue, Dec 31, 2013 at 6:26 PM, Kuba Janoszek notifications@gitpro.ttaallkk.topwrote:

Guys please.... - stop do anything right now and get drunk. It's New
Year's
Eve :)

On 31 December 2013 18:24, Sebastian Pawluś notifications@gitpro.ttaallkk.topwrote:

No worries, I will look at this some time in the next year ;)

First short comment we, I don't know how mobile handles it but we need
to
consider also an use case when user says NO for geolocation.

On Tue, Dec 31, 2013 at 6:15 PM, Jack Wearden notifications@gitpro.ttaallkk.topwrote:

I got a really hacky version running in NotBobTheBuilder/commitcoffee@ecac396<

NotBobTheBuilder@ecac396af5ba8e99b4fa387ab1cb8608b83f643e>,

but the UX is nasty and the map zooms in too far. Didn't take much
work
to
get going though! I'll tidy it up over the next few days.


Reply to this email directly or view it on GitHub<
https://github.com/xando/commitcoffee/issues/133#issuecomment-31402664>
.


Reply to this email directly or view it on GitHub<
https://github.com/xando/commitcoffee/issues/133#issuecomment-31403029>
.


Reply to this email directly or view it on GitHubhttps://github.com//issues/133#issuecomment-31403111
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants