CA-296532: mpathalert log spam #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krizex
suggested changes
Sep 6, 2018
http-svr/xmlrpc_client.ml
Outdated
| @@ -21,6 +21,8 @@ open D | |||
|
|
|||
| module E = Debug.Make(struct let name = "mscgen" end) | |||
|
|
|||
| let initialize_logging = Debug.disable ~level:Syslog.Debug "mscgen" | |||
lindig
reviewed
Sep 6, 2018
http-svr/xmlrpc_client.ml
Outdated
| @@ -371,6 +373,7 @@ module Protocol = functor(F: FORMAT) -> struct | |||
| (* Caution: req can contain sensitive information such as passwords in its parameters, | |||
| * so we should not log the parameters or a string representation of the whole thing. | |||
| * The name should be safe though, e.g. req.Rpc.name when F is XMLRPC. *) | |||
| initialize_logging; | |||
There was a problem hiding this comment.
initialize_logging needs to be a function if you want to call it like this. Currently this is just a unit value.
minli1
force-pushed
the
private/minl1/CA-296532
branch
from
3061a0f
to
da8bf21
Compare
gaborigloi
reviewed
Sep 6, 2018
http-svr/xmlrpc_client.ml
Outdated
| @@ -21,6 +21,8 @@ open D | |||
|
|
|||
| module E = Debug.Make(struct let name = "mscgen" end) | |||
|
|
|||
| let initialize_logging () = Debug.disable ~level:Syslog.Debug "mscgen" | |||
There was a problem hiding this comment.
Does it work if we do it once here:
let () = Debug.disable ~level:Syslog.Debug "mscgen"That would be more efficient than calling this in every rpc call.
There was a problem hiding this comment.
Yes, good point. I will change and test. thanks.
minli1
force-pushed
the
private/minl1/CA-296532
branch
2 times, most recently
from
4881643
to
9474829
Compare
Disable Debug Level for brand 'mscgen' Signed-off-by: Min Li <min.li1@citrix.com>
minli1
force-pushed
the
private/minl1/CA-296532
branch
from
9474829
to
2447c33
Compare
edwintorok
approved these changes
Sep 6, 2018
gaborigloi
approved these changes
Sep 6, 2018
krizex
approved these changes
Sep 7, 2018
|
Test passed, help to merge please. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable debug log level for brand 'mscgen'
Signed-off-by: Min Li min.li1@citrix.com