Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VM shutdowns: do not block the calls to the domains prematurely #6025

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

psafont
Copy link
Member

@psafont psafont commented Sep 30, 2024

I'm opening the PR to comment on this behaviour, since this should make possible to shutdown FreeBSD kernels.

The crux of the matter is that Just because a domain is not advertising it can shutdown cooperatively doesn't mean it can't at all. Doing it in any case would make it work with FreeBSD kernels, but I don't know whether this can break some expectations in xencenter about other guests.

Just because a domain is not advertising it can shutdown cooperatively
doesn't mean it can't at all.

Try to shut them down in any case.

Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
@andyhhp
Copy link
Contributor

andyhhp commented Sep 30, 2024

The feature-$foo flags were added a decade after Xen support had found its way into various open source kernels.

While the presence of explicit =1 or =0 values in the feature flags does indicate a guest aware of the new scheme, the absence of features does not indicate that the guest is Xen-unaware.

@lindig
Copy link
Contributor

lindig commented Oct 2, 2024

I believe the commit should explain the semantics of the strict flag; what happens in both cases and what we are using now.

@psafont
Copy link
Member Author

psafont commented Oct 2, 2024

I can add an explanation to the strict mode in the call. I believe it's misnamed, the parameter enforces that the guest is actively advertising support for the feature using an appropriate xenstore key. This is not required by the spec, and it's not clear whether not enforcing could break windows guests, hence the PR being in draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants