Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http-lib: add backtrace to logs on connection without response #6028

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

http-lib: add backtrace to logs on connection without response #6028

wants to merge 6 commits into from
+118 −78

Commits on Oct 9, 2024

  1. http-lib: add backtrace to logs on connection without response 

    Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
    @psafont
    psafont committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    008a813 View commit details
    Browse the repository at this point in the history

  2. http-lib: convert bash script to cram tests 

    Gives more flexibility in tests. Now the results from the client aren't
printed, but weren't important to pass the test anyway.

Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
    @psafont
    psafont committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    ed96146 View commit details
    Browse the repository at this point in the history

  3. http-lib: prepare test client for more commands 

    Current behaviour for displaying stats is done with the --perf parameter

Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
    @psafont
    psafont committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    3bef65f View commit details
    Browse the repository at this point in the history

  4. http-libs: add test about error logging 

    While this does not exercise the exact error that can happen in long
migrations, it gets logged in a similar way.

There's no easy way to trigger the issue, the best chance is to send a
malformed response to trigger a Parse_error.

I did modify the code in http_client and verified that current code can produce
the logging, with backtraces successfully, when set up properly (like in the
test client)

Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
    @psafont
    psafont committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    d8bd9f2 View commit details
    Browse the repository at this point in the history

  5. http-lib: use let@ for perf testing of the client 

    No functional difference

Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
    @psafont
    psafont committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    cda6194 View commit details
    Browse the repository at this point in the history

  6. http-lib: make perf shorter 

    Taking measurements in practice doesn't lead to improved accuracy. Also change
the tests so more than one sample is collected and can know how noisy the
measurements really are.

Here's an example of a run, including the result before the change:

```
   $ ./test_client.exe --perf
-  1 thread non-persistent connections:        4896.0 +/- 0.0 RPCs/sec
-  1 thread non-persistent connections (query):        4811.0 +/- 0.0 RPCs/sec
-  10 threads non-persistent connections: 7175.0 +/- 0.0 RPCs/sec
-  1 thread persistent connection:             16047.0 +/- 0.0 RPCs/sec
-  10 threads persistent connections: 7713.0 +/- 0.0 RPCs/sec
+  1 thread non-persistent connections:         5042.0 +/- 247.5 RPCs/sec
+  1 thread non-persistent connections (query): 5173.0 +/- 216.0 RPCs/sec
+  10 threads non-persistent connections:       7678.0 +/- 2241.2 RPCs/sec
+  1 thread persistent connection:              21814.0 +/- 2124.6 RPCs/sec
+  10 threads persistent connections:           10154.0 +/- 2461.9 RPCs/sec
```

Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
    @psafont
    psafont committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    4f86441 View commit details
    Browse the repository at this point in the history