Upstream Xen has xenmmap as separate package, no xenctrl.xenmmap #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we disable transitive dependencies in dune then we need to depend on 'xenmmap' in Koji, not 'xenctrl.xenmmap' (which doesn't exist). But 'xenmmap' has no 'mock', so rename the library to have one. Signed-off-by: Edwin Török <edwin.torok@cloud.com>
|
will also need an xs-opam update for the github CI (no change needed for koji). |
psafont
approved these changes
May 31, 2023
|
Are there any more conversions needed? the rest of libraries follow the same structure |
psafont
approved these changes
May 31, 2023
|
This was the only one that was failing at the moment. |
lindig
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we disable transitive dependencies in dune then we need to depend on 'xenmmap' in Koji, not 'xenctrl.xenmmap' (which doesn't exist). But 'xenmmap' has no 'mock', so rename the library to have one.