Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packages/upstream/rpclib*/opam: dev-repo must use github https #646

Merged

Conversation

bernhardkaindl
Copy link
Contributor

Fix opam source --dev rpclib -vv to use the github https URL instead of the git:// protocol which was discontinued by github.

Co-authored-by: @edwintorok

Fix `opam source --dev rpclib -vv` to use the github https URL
instead of the git:// protocol which was discontinued by github.

Co-authored-by: Edwin Török <edwin.torok@cloud.com>
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
Copy link
Contributor

@edwintorok edwintorok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to make some changes to rpclib to port it to Python3, fixing this URL makes that easier, because then opam source --dev rpclib can be used (Github turned off git:// support a while ago and only https works)

@MarkSymsCtx MarkSymsCtx self-requested a review June 26, 2023 10:29
@lindig
Copy link
Collaborator

lindig commented Jun 26, 2023

There are more instances of git://github.com in this repository and branch. Should we not change all of them?

Replace git://github.* with https://gitub*.git

Fix `opam source --dev $package` to use the github https URL
instead of the git:// protocol which was discontinued by github.

Command used:
sed -i '/git:/s/"$/.git"/;s/.git.git"/.git"/;s/git:/https:/' */*/*/opam

These are the changed dev-repo lines:
dev-repo: "https://github.com/lindig/polly.git"
dev-repo: "https://github.com/mirage/ocaml-rpc.git"
dev-repo: "https://github.com/ocaml-batteries-team/batteries-included.git"
dev-repo: "https://github.com/xapi-project/backtrace.git"
dev-repo: "https://github.com/xapi-project/xapi-test-utils.git"
dev-repo: "https://github.com/xapi-project/xcp-idl.git"
dev-repo: "https://github.com/xapi-project/xen-api.git"

Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
@bernhardkaindl
Copy link
Contributor Author

@lindig, @edwintorok, @MarkSymsCtx : JFYI:

I pushed the remaining rev-repo updates from git://gitub to https://gitub.*.git

@lindig lindig merged commit 6dff8c9 into xapi-project:master Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants