Skip to content
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.

PB-122: handle sigint properly #250

Merged

Conversation

little-dude
Copy link
Contributor

@little-dude little-dude commented Jan 31, 2020

References

https://xainag.atlassian.net/browse/PB-122

Summary

Guard the call to main() at the end of __main__.py. Otherwise
we're starting the coordinator twice by calling the coordinator
command: once when __main__.py is imported, and once when the
entrypoint (__main.py__::main) is called.


Reviewer checklist

Reviewer agreement:

  • Reviewers assign themselves at the start of the review.
  • Reviewers do not commit or merge the merge request.
  • Reviewers have to check and mark items in the checklist.

Merge request checklist

  • Conforms to the merge request title naming XP-XXX <a description in imperative form>.
  • Each commit conforms to the naming convention XP-XXX <a description in imperative form>.
  • Linked the ticket in the merge request title or the references section.
  • Added an informative merge request summary.

Code checklist

  • Conforms to the branch naming XP-XXX-<a_small_stub>.
  • Passed scope checks.
  • Added or updated tests if needed.
  • Added or updated code documentation if needed.
  • Conforms to Google docstring style.
  • Conforms to XAIN structlog style.

Summary:

Guard the call to `main()` at the end of `__main__.py`. Otherwise
we're starting the coordinator twice by calling the `coordinator`
command: once when `__main__.py` is imported, and once when the
entrypoint (`__main.py__::main`) is called.

References:

https://xainag.atlassian.net/browse/PB-122
@little-dude little-dude merged commit e010b56 into xaynetwork:development Jan 31, 2020
@little-dude little-dude deleted the PB-122-exit-properly branch January 31, 2020 14:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants