Skip to content
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.

PB-402 Add more logs #281

Merged
merged 4 commits into from
Feb 12, 2020
Merged

Conversation

Robert-Steiner
Copy link
Contributor

@Robert-Steiner Robert-Steiner commented Feb 10, 2020

References

PB-402

Summary

  • made the current logs more expressive and less visual noisy:

    • reply=LATER instead of reply=1
    • state=ROUND instead of state=1
    • message_type=HeartbeatRequest instead of message_type=<class 'xain_proto.fl.coordinator_pb2.HeartbeatRequest'>
  • add logs for message_byte_size, current_participants_count

Are there any open tasks/blockers for the ticket?

No


Reviewer checklist

Reviewer agreement:

  • Reviewers assign themselves at the start of the review.
  • Reviewers do not commit or merge the merge request.
  • Reviewers have to check and mark items in the checklist.

Merge request checklist

  • Conforms to the merge request title naming XP-XXX <a description in imperative form>.
  • Each commit conforms to the naming convention XP-XXX <a description in imperative form>.
  • Linked the ticket in the merge request title or the references section.
  • Added an informative merge request summary.

Code checklist

  • Conforms to the branch naming XP-XXX-<a_small_stub>.
  • Passed scope checks.
  • Added or updated tests if needed.
  • Added or updated code documentation if needed.
  • Conforms to Google docstring style.
  • Conforms to XAIN structlog style.

@Robert-Steiner Robert-Steiner changed the base branch from master to development February 10, 2020 14:53
@Robert-Steiner Robert-Steiner force-pushed the feature/PB-402-add-more-logs branch 2 times, most recently from 60357f8 to bb0b881 Compare February 10, 2020 15:40
@Robert-Steiner Robert-Steiner changed the title Feature/pb 402 add more logs PB-402 Add more logs Feb 10, 2020
@Robert-Steiner Robert-Steiner marked this pull request as ready for review February 10, 2020 17:11
little-dude
little-dude previously approved these changes Feb 11, 2020
Copy link
Contributor

@little-dude little-dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will make the logs much more useful 👍

xain_fl/coordinator/coordinator.py Outdated Show resolved Hide resolved
@Robert-Steiner Robert-Steiner merged commit fa14462 into development Feb 12, 2020
@Robert-Steiner Robert-Steiner deleted the feature/PB-402-add-more-logs branch February 12, 2020 13:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants