This repository has been archived by the owner on Aug 30, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 28
PB-558 Render the swagger files in the documentation #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robert-Steiner
requested review from
janpetschexain,
little-dude and
finiteprods
April 6, 2020 09:20
little-dude
reviewed
Apr 6, 2020
little-dude
reviewed
Apr 6, 2020
little-dude
reviewed
Apr 6, 2020
little-dude
reviewed
Apr 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a couple question. I'd like to build the docs and see how it looks before approving. I also think we could strip down the README quite a lot: all of the implementation details belong to the Rust doc imo. I'll suggest some changes in that area.
- use a separate README for the repo and for readthedocs - remove the implementation details from the repo's main README. That part of the documentation belong to the Rust documentation and was slightly outdated anyway - remove the keras example README, which was outdated and redundant with the instructions in the repo's README
cleanup README files
little-dude
approved these changes
Apr 6, 2020
little-dude
approved these changes
Apr 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference:
Summary