Skip to content
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.

generalised scalar extension #496

Merged
merged 7 commits into from
Aug 21, 2020
Merged

generalised scalar extension #496

merged 7 commits into from
Aug 21, 2020
+525 −388

Commits on Aug 20, 2020

  1. mask generalised scalar

    @finiteprods
    finiteprods committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    beadc8e View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2020

  1. update, sum2 phase: message payloads, masked scalar / scalar mask agg 

    =====================================================================

update msg payload from bytes with masked scalar

masked scalar to bytes

scalar aggregation in state machine update phase

pass scalar agg from update to sum2 phase

derive scalar mask from seed; aggregate scalar masks

add aggregate scalar mask to sum2 message payload

rename aggregation to model_agg and scalar_agg

collect scalar mask sums
    @finiteprods
    finiteprods committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    f3bcb63 View commit details
    Browse the repository at this point in the history

  2. unmask phase: unmask scalar mask, correction step 

    =================================================

pass scalar pair sum2 -> unmask; rename mask_dict

add scalar agg & mask dict to unmask phase

correction step

rename agg fields
    @finiteprods
    finiteprods committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    8b6c1a6 View commit details
    Browse the repository at this point in the history

  3. remove scalar distribution

    @finiteprods
    finiteprods committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    fbedb8d View commit details
    Browse the repository at this point in the history

  4. update message payload offset bug + associated test fixes 

    remaining test fixes
    @finiteprods
    finiteprods committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    0371e42 View commit details
    Browse the repository at this point in the history

  5. masking doctest fixes 

    fmt
    @finiteprods
    finiteprods committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    b081555 View commit details
    Browse the repository at this point in the history

  6. remove reappearing Scalar type after rebase 

    fmt

float literal; docstring for correction fn
    @finiteprods
    finiteprods committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    cb66c7d View commit details
    Browse the repository at this point in the history