Skip to content
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.

Expose current state of the client & make scalar configurable #507

Merged
merged 2 commits into from
Sep 7, 2020

Conversation

Robert-Steiner
Copy link
Contributor

Summary:

  • expose current state of the client
  • make scalar configurable

@codecov
Copy link

codecov bot commented Aug 26, 2020

Codecov Report

Merging #507 into master will decrease coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #507      +/-   ##
==========================================
- Coverage   58.21%   58.13%   -0.08%     
==========================================
  Files          63       63              
  Lines        2996     3000       +4     
==========================================
  Hits         1744     1744              
- Misses       1252     1256       +4     
Impacted Files Coverage Δ
rust/xaynet-client/src/mobile_client/client.rs 0.00% <0.00%> (ø)
rust/xaynet-client/src/mobile_client/mod.rs 0.00% <0.00%> (ø)
...t-client/src/mobile_client/participant/awaiting.rs 76.47% <ø> (ø)
...xaynet-client/src/mobile_client/participant/mod.rs 0.00% <ø> (ø)
...aynet-client/src/mobile_client/participant/sum2.rs 13.88% <0.00%> (-0.40%) ⬇️
...net-client/src/mobile_client/participant/update.rs 38.46% <0.00%> (-3.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f22e75b...7239149. Read the comment docs.

@Robert-Steiner Robert-Steiner marked this pull request as ready for review August 27, 2020 11:34
provide method that returns the current state of the client
@Robert-Steiner Robert-Steiner force-pushed the mobile_client_expose_type branch 2 times, most recently from a6234a6 to afe8e92 Compare September 4, 2020 08:29
Copy link
Contributor

@finiteprods finiteprods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question for clarification, otherwise the AggregationConfig related changes look good.

rust/xaynet-client/src/mobile_client/mod.rs Show resolved Hide resolved
@Robert-Steiner
Copy link
Contributor Author

Thanks for reviewing 👍

@Robert-Steiner Robert-Steiner merged commit 6e4a511 into master Sep 7, 2020
@Robert-Steiner Robert-Steiner deleted the mobile_client_expose_type branch September 7, 2020 10:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants