This repository has been archived by the owner on Aug 30, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#524 introduced various changes to tidy the API especially around the generalised scalar extension. As such, the masking tests (several hundred tests generated by the macros
test_masking
,test_aggregation
andtest_masking_and_aggregation
) now cover the (un)masking and aggregation of the scalar as well.An issue was discovered in #524 where the unmasked scalar sum appeared larger than expected. This lead to "closeness checks" of model weights to exceed the desired tolerance, and so those tests (at least, those based on
test_masking
andtest_masking_and_aggregation
) were temporarily relaxed. This PR contains a fix for that issue, which was due to an inconsistency in the use of the PRNG in masking vs unmasking.All masking tests are now reinstated, although a related issue has been found with a few test cases of
test_masking_and_aggregation
. Again, closeness checks break for those cases - for now, a slightly fewer number of models are aggregated to keep the difference within tolerance.On a separate note, this PR also contains a more complete implementation of
MaskObjectBuffer
.