Add controller stub and circle CI configuation #66
Conversation
skade
requested review from
danieljanes,
r-marques and
tanertopal
as code owners
.circleci/config.yml
Outdated
| - run: | ||
| name: install dependencies | ||
| command: | | ||
| rustup install nightly |
There was a problem hiding this comment.
Is it ok if we use a fixed version of rust instead of the nightly or do you see any advantages in using the nightly?
There was a problem hiding this comment.
Yes, specifically async/await. It's 8 weeks out and I wouldn't start a networked codebase without it nowadays. We will be able to switch to beta by September 26.
There was a problem hiding this comment.
Ok, cool. Lets fix the version as soon as there is a stable rust version with async/await
There was a problem hiding this comment.
It might be a good idea to pin to a specific nightly though
There was a problem hiding this comment.
And we can maybe use a rust-toolchain file. That way this two commands aren't really needed and everyone would be using the same version.
There was a problem hiding this comment.
Right. Added a rust-toolchain file and skipped the install step.
|
Feel free to merge |
fix crash after training finishes
New version of #65, checking if CircleCI runs.