This repository has been archived by the owner on Aug 30, 2022. It is now read-only.
Tighten up Rust CI #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matklad
requested review from
danieljanes,
r-marques and
tanertopal
as code owners
matklad
commented
Sep 18, 2019
| @@ -0,0 +1,2 @@ | |||
| version = "Two" | |||
| use_small_heuristics = "Max" | |||
There was a problem hiding this comment.
That's not the default, but this is what compiler uses and what I personally prefer as well.
By default, rustfmt puts every thing on a separate line, which makes for a low-dencity code (so that formatting code with rustfmt for the first time is something like 1.5x increase in sloc).
This might be better to review diffs, but, to my mind, it makes reading code outside of diff (ie, most of the time) harder.
I don't have a strong opinion here thogh, we can stick to vanilla config as well
There was a problem hiding this comment.
I have no preference from my side so I'm ok to go with this.
r-marques
approved these changes
Sep 18, 2019
|
Merging optimistically, changing style is trivial while we have a dozen lines of code. |
little-dude
added a commit
to little-dude/xain-fl
that referenced
this pull request
Mar 23, 2020
Improve the dummy example
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.