Miscellaneous fixes to vCPUs warnings #3160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
CitrixChris
previously approved these changes
Jun 19, 2023
jijiang
previously approved these changes
Jun 19, 2023
danilo-delbusso
dismissed stale reviews from jijiang and CitrixChris
PR not ready yet
Adds a new field in `SelectMultipleVMDestinationPage`: `AllSelectedTargets`. This new field contains a list of all hosts that have been selected. This way `ImportSelectHostPage` can check for each `Host` that has been selected individually and add more relevant messages Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
danilo-delbusso
changed the title
_ovfVCpusCount.Clear outside content check loop
danilo-delbusso
commented
Jun 19, 2023
danilo-delbusso
added
ITE
CitrixChris
approved these changes
Jun 26, 2023
danilo-delbusso
added
1 approval
kc284
requested changes
Jul 3, 2023
XenAdmin/Wizards/GenericPages/SelectMultipleVMDestinationPage.cs
Outdated
Show resolved
Hide resolved
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
danilo-delbusso
added
updated
CitrixChris
approved these changes
Jul 10, 2023
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
CitrixChris
approved these changes
Jul 10, 2023
kc284
approved these changes
Jul 10, 2023
kc284
added
2 approvals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found these while writing test scenarios for the changes.
_ovfVCpusCountwas being cleared at every iteration and only one CPU count remained at the end of it. Caused the > 32 vCPUs to not appear on multi-VM imports with mixed vCPU countsSelectedTarget, which is the last item that was selected. As part of this, I also added a new message and modified an existing one.