-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Dispatcher.swift #350
Conversation
1b90536
to
77e07be
Compare
Codecov Report
@@ Coverage Diff @@
## master #350 +/- ##
=========================================
+ Coverage 44.15% 44.3% +0.15%
=========================================
Files 31 30 -1
Lines 3889 3860 -29
=========================================
- Hits 1717 1710 -7
+ Misses 2172 2150 -22
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Does this close #341?
Did you mean #275 ? |
Thanks, feels great to have this cleaned up! |
This PR removes
Dispatcher.swift
🎉This ended up bigger than I expected 😅
Please let me know if the change is too big. I think we can easily split it up into smaller pieces.