Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Dispatcher.swift #350

Merged
merged 8 commits into from
Nov 17, 2018
Merged

Remove Dispatcher.swift #350

merged 8 commits into from
Nov 17, 2018

Conversation

mmatoszko
Copy link
Member

@mmatoszko mmatoszko commented Nov 15, 2018

This PR removes Dispatcher.swift 🎉
This ended up bigger than I expected 😅
Please let me know if the change is too big. I think we can easily split it up into smaller pieces.

@codecov-io
Copy link

Codecov Report

Merging #350 into master will increase coverage by 0.15%.
The diff coverage is 35.71%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #350      +/-   ##
=========================================
+ Coverage   44.15%   44.3%   +0.15%     
=========================================
  Files          31      30       -1     
  Lines        3889    3860      -29     
=========================================
- Hits         1717    1710       -7     
+ Misses       2172    2150      -22
Impacted Files Coverage Δ
Sources/XiEditor/RPCSending.swift 58.08% <ø> (+1.1%) ⬆️
Sources/XiEditor/EditViewController.swift 27.41% <0%> (ø) ⬆️
Tests/XiEditorTests/XiCoreTests.swift 94.31% <0%> (-4.5%) ⬇️
Sources/XiEditor/AppDelegate.swift 36.76% <100%> (-1.05%) ⬇️
Sources/XiEditor/XiCore.swift 94.59% <33.33%> (-5.41%) ⬇️
Sources/XiEditor/Document.swift 56.07% <33.33%> (-0.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d96c2d...77e07be. Read the comment docs.

Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Does this close #341?

@mmatoszko
Copy link
Member Author

Did you mean #275 ?
I think so, yes 👍

@cmyr cmyr merged commit 59d72e9 into xi-editor:master Nov 17, 2018
@cmyr
Copy link
Member

cmyr commented Nov 17, 2018

Thanks, feels great to have this cleaned up!

@mmatoszko mmatoszko deleted the remove-dispatcher branch November 17, 2018 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants