first attempt at resolving nil dereference errors #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shlomi-dr
commented
Jan 9, 2022
Comment on lines
+305
to
+308
| if table.Schema.Type != nil { | ||
| pagesMapList[index][name], _ = layout.TableToDataPages(table, int32(pw.PageSize), | ||
| pw.CompressionType) | ||
| } |
There was a problem hiding this comment.
Tried to wrap the invocation with a nil guard, and that seems to have helped.
Ran the test suite and it looks fine.
Is this correct? Am I missing something?
shlomi-dr
force-pushed
the
shlomi/nil-dereference
branch
2 times, most recently
from
a60aec2
to
5f74d27
Compare
|
This PR is related to #395 and I'd suggest fix it like #407, which changes function signature to return The preferred way may introduce large scale refactor though. |
zolstein
pushed a commit
to zolstein/parquet-go
that referenced
this pull request
Jun 23, 2023
* better estimation of the size of decode output buffers * detect whether some encodings support decoding values in place * fix page size * chunk large writes of rows * support configuring the sorting buffer pool * debug page buffer ref count * track stack traces of buffer allocations * fix buffer reference counting * fix backward compatiblity with Go 1.17 * set PARQUETGODEBUG=tracbuf=1 in CI * reduce memory waste of row buffer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was battling some nil dereference that was concealed deep in the library. I added a bunch of
debug.Stack()calls to retain the original stacktrace, and found that in the following sectionpTis some timesnil:parquet-go/common/common.go
Lines 667 to 671 in 5f74d27
Not sure why that happens, see below comment for proposed fix