Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing spans as per WRP specifications #295

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

gbuddappagari
Copy link

No description provided.

@codecov
Copy link

codecov bot commented Aug 3, 2018

Codecov Report

Merging #295 into master will decrease coverage by 0.28%.
The diff coverage is 47.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #295      +/-   ##
==========================================
- Coverage   68.21%   67.92%   -0.29%     
==========================================
  Files         174      174              
  Lines       11444    11630     +186     
==========================================
+ Hits         7806     7900      +94     
- Misses       2903     2956      +53     
- Partials      735      774      +39
Impacted Files Coverage Δ
wrp/messages.go 100% <ø> (ø) ⬆️
wrp/messages_codec.go 29.83% <44.88%> (+0.74%) ⬆️
wrp/wrphttp/headers.go 93.93% <86.2%> (-2.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c6a991...14df170. Read the comment docs.

@CLAassistant
Copy link

CLAassistant commented Aug 2, 2019

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

Codecov Report

Merging #295 into master will decrease coverage by 4.22%.
The diff coverage is 47.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #295      +/-   ##
==========================================
- Coverage   72.15%   67.92%   -4.23%     
==========================================
  Files         199      174      -25     
  Lines       11737    11630     -107     
==========================================
- Hits         8469     7900     -569     
- Misses       2595     2956     +361     
- Partials      673      774     +101
Impacted Files Coverage Δ
wrp/messages.go 100% <ø> (ø) ⬆️
wrp/messages_codec.go 29.83% <44.88%> (+1.24%) ⬆️
wrp/wrphttp/headers.go 93.93% <86.2%> (-1.19%) ⬇️
wrp/wrphttp/decoders.go 62.35% <0%> (-37.65%) ⬇️
device/handlers.go 82.41% <0%> (-5.96%) ⬇️
device/manager.go 55.12% <0%> (-2.81%) ⬇️
webhook/aws/sns_handler.go 77.07% <0%> (-0.66%) ⬇️
secure/handler/authorizationHandler.go 86.25% <0%> (-0.34%) ⬇️
server/viper.go 96.72% <0%> (-0.06%) ⬇️
... and 91 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 760e191...14df170. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants