Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Incompatible versions of Minikube and Kubernetes #172

Merged
merged 7 commits into from
Jan 29, 2023

Conversation

ChengjieLi28
Copy link
Contributor

@ChengjieLi28 ChengjieLi28 commented Jan 29, 2023

Kubernetes is incompatible with Minikube 1.29.0(latest for now).
Here I use fixed 1.23.15 K8s to fix this.

Related issues: kubernetes/minikube#4172

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added the bug Something isn't working label Jan 29, 2023
@XprobeBot XprobeBot added this to the v0.1.2 milestone Jan 29, 2023
@codecov
Copy link

codecov bot commented Jan 29, 2023

Codecov Report

Merging #172 (e20d1c9) into main (530d564) will increase coverage by 21.50%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #172       +/-   ##
===========================================
+ Coverage   77.57%   99.07%   +21.50%     
===========================================
  Files          39       39               
  Lines        1739     1739               
  Branches      275      275               
===========================================
+ Hits         1349     1723      +374     
+ Misses        384        5      -379     
- Partials        6       11        +5     
Flag Coverage Δ
kubernetes 98.70% <ø> (?)
unittests 77.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/xorbits/deploy/kubernetes/config.py 99.09% <0.00%> (+66.16%) ⬆️
python/xorbits/deploy/kubernetes/client.py 97.18% <0.00%> (+72.76%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ChengjieLi28 ChengjieLi28 changed the title BUG: Missing extra config for minikube BUG: Incompatible versions of Minikube and Kubernetes Jan 29, 2023
Copy link
Contributor

@qianduoduo0904 qianduoduo0904 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@aresnow1 aresnow1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 7fbe6b4 into xorbitsai:main Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants