Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix redirects yielding "null" #7

Merged
merged 1 commit into from
Apr 12, 2022
Merged

Fix redirects yielding "null" #7

merged 1 commit into from
Apr 12, 2022

Conversation

thekid
Copy link
Member

@thekid thekid commented Apr 12, 2022

Instead of actually performing the redirect, the HTTP API Gateway simply yielded a plain text response showing the word null. Problem is that the response might not have been flushed correctly, fix is to call Response::end().

@thekid thekid added the bug Something isn't working label Apr 12, 2022
@thekid thekid merged commit 5f98269 into main Apr 12, 2022
@thekid thekid deleted the fix/redirects branch April 12, 2022 10:51
@thekid
Copy link
Member Author

thekid commented Apr 12, 2022

Released in https://github.com/xp-forge/lambda-ws/releases/tag/v1.1.1

@thekid thekid mentioned this pull request Apr 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thekid