Don't mutate cached data in DatasetInfoPlugin #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multiple requests to the /info endpoint are failing. The DatasetInfoPlugin is changing the cached metadata by removing the `_ARRAY_DIMENSIONS` attribute key which is required on subsequent calls. I did not dive into the caching internals to figure out why the the value is mutable at all. If it is a simple dict on the backend, the returned cache values could be being changed inside the cache dict itself. Added a test that fails without the change!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple requests to the /info endpoint are failing. The DatasetInfoPlugin is changing the cached metadata by removing the
_ARRAY_DIMENSIONSattribute key which is required on subsequent calls. I did not dive into the caching internals to figure out why the value is mutable at all. If it is a simple dict on the backend, the returned cache values could be being changed inside the cache dict itself.Added a test that fails without the change!