Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default ZarrPlugin prefix to /zarr #188

Merged
merged 4 commits into from
May 5, 2023

Conversation

abkfenris
Copy link
Member

Closes #182

@abkfenris
Copy link
Member Author

@jhamman I might need some Zarr help here. It looks like it's failing as the non-dimension coordinate order isn't matching in the metadata tests.

I haven't been able to replicate it against Python 3.9.15, Xarray 2023.4.2, Zarr 2.14.2 (or 2.11.3 before I bumped Zarr to see if that was mismatched) locally. I didn't see anything in Xarray or Zarr's changelog that made me think that there would be a change in either that would affect the ordering of lat and lon.

@jhamman
Copy link
Contributor

jhamman commented Apr 29, 2023

I re-triggered the failed CI and things past. Not sure what was up with the previous failed run but I'm wondering if it had picked up an old/malformed cache.

@jhamman
Copy link
Contributor

jhamman commented Apr 29, 2023

Oh, do we need some doc updates with this?

@jhamman jhamman mentioned this pull request Apr 29, 2023
@abkfenris
Copy link
Member Author

It just failed the same way when landing the pydata-theme PR. I'm going to try explicitly sorting the coord names to see if that helps make the ordering of coords predictable at least from Xpublish's side.

And yes, because I had big doc changes in flight I'm going to make the updates there #180.

@abkfenris
Copy link
Member Author

Ok, so we are sorting coordinates, but Xarray/Zarr isn't?

@abkfenris
Copy link
Member Author

And that also passes when run again.

@abkfenris
Copy link
Member Author

It looks like xarray sets the value here, and I can't make out any sorting which would make it stable. https://github.com/pydata/xarray/blob/25d9a28e12141b9b5e4a79454eb76ddd2ee2bc4d/xarray/conventions.py#L690-L697

@abkfenris abkfenris merged commit d80a984 into xpublish-community:main May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set zarr router prefix
2 participants