-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logs for OLM resources #419
base: master
Are you sure you want to change the base?
Add logs for OLM resources #419
Conversation
fabric8 issue: fabric8io/kubernetes-client#2784 |
1e771d8
to
765dd4c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor issues. Otherwise as a draft looks good. I raised one point about CustomResourceHelper
though.
Moreover, can you create an XTF issue for this?
junit5/src/main/java/cz/xtf/junit5/extensions/helpers/CustomResourceHelper.java
Outdated
Show resolved
Hide resolved
junit5/src/main/java/io/fabric8/openshift/api/model/operatorhub/v1alpha1/OperatorVersion.java
Outdated
Show resolved
Hide resolved
bbe3e25
to
c6258ab
Compare
c6258ab
to
87952bd
Compare
87952bd
to
42a179c
Compare
@tommaso-borgato can you please list requirements for the PR? What blocks us and so on. It helps us to track it efficiently. |
@istraka I wrote it in the description: shall I white it somewhere else? |
@tommaso-borgato Oh, I must have missed it, I am sorry. It is okay, thanks. |
Hi @tommaso-borgato (CC @simkam and @istraka), FYI I see that fabric8io/kubernetes-client#2918 has been merged already. Anyway I'd raise another issue here, related to this one, which is about the fact that in we noticed an IOException being thrown in case the logs have been previously downloaded. I suspect the changes here could be affected as well since they were first developed externally and then ported right here. Again, this is just an heads-up for investigation which should be verified before merging this. |
This PR contains modifications to add logs for OLM resources;
Please make sure your PR meets the following requirements: