Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logs for OLM resources #419

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tommaso-borgato
Copy link
Contributor

@tommaso-borgato tommaso-borgato commented Mar 22, 2021

This PR contains modifications to add logs for OLM resources;

NOTE: the PR is in Draft because we are waiting for fabric8io/kubernetes-client#2918 to be merged;
PR fabric8io/kubernetes-client#2918 removes the following error:

com.fasterxml.jackson.databind.exc.MismatchedInputException: Cannot construct instance of 
`io.fabric8.openshift.api.model.operatorhub.v1alpha1.OperatorVersion` (although at least one Creator exists): no String- 
argument constructor/factory method to deserialize from String value ('2.1.1')
 at [Source: (BufferedInputStream); line: 1, column: 11260] (through reference chain: 
io.fabric8.openshift.api.model.operatorhub.v1alpha1.ClusterServiceVersionList["items"]->java.util.ArrayList[0]- 
io.fabric8.openshift.api.model.operatorhub.v1alpha1.ClusterServiceVersion["spec"]- 
io.fabric8.openshift.api.model.operatorhub.v1alpha1.ClusterServiceVersionSpec["version"])

Please make sure your PR meets the following requirements:

  • Pull Request contains a description of the changes
  • Pull Request does not include fixes for multiple issues/topics
  • Code is formatted, imports ordered, code compiles and tests are passing
  • Code is self-descriptive and/or documented

@tommaso-borgato tommaso-borgato marked this pull request as draft March 22, 2021 16:54
@simkam
Copy link
Contributor

simkam commented Mar 22, 2021

fabric8 issue: fabric8io/kubernetes-client#2784

Copy link
Contributor

@istraka istraka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor issues. Otherwise as a draft looks good. I raised one point about CustomResourceHelper though.

Moreover, can you create an XTF issue for this?

@tommaso-borgato tommaso-borgato force-pushed the feature/OLM_ADD_LOGS branch 3 times, most recently from bbe3e25 to c6258ab Compare March 23, 2021 19:08
@tommaso-borgato
Copy link
Contributor Author

tommaso-borgato commented Mar 24, 2021

Moreover, can you create an XTF issue for this?

#420

@istraka ^^^

@istraka
Copy link
Contributor

istraka commented Mar 29, 2021

@tommaso-borgato can you please list requirements for the PR? What blocks us and so on. It helps us to track it efficiently.

@tommaso-borgato
Copy link
Contributor Author

@istraka I wrote it in the description: shall I white it somewhere else?

@istraka
Copy link
Contributor

istraka commented Mar 29, 2021

@tommaso-borgato Oh, I must have missed it, I am sorry. It is okay, thanks.

@fabiobrz
Copy link

Hi @tommaso-borgato (CC @simkam and @istraka), FYI I see that fabric8io/kubernetes-client#2918 has been merged already.

Anyway I'd raise another issue here, related to this one, which is about the fact that in we noticed an IOException being thrown in case the logs have been previously downloaded. I suspect the changes here could be affected as well since they were first developed externally and then ported right here.

Again, this is just an heads-up for investigation which should be verified before merging this.

@tommaso-borgato tommaso-borgato added this to the BACKLOG milestone Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants