[#572] Allow image url with more than 2 slashes to be parsed properly. #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simkam
requested changes
Sep 2, 2024
mnovak1
force-pushed
the
image-url-parsing
branch
from
c500712
to
79cb1f5
Compare
simkam
approved these changes
Sep 2, 2024
mchoma
reviewed
Sep 2, 2024
| @@ -70,7 +71,10 @@ public static Image from(String imageUrl) { | |||
| repoTag = slashTokens[2]; | |||
| break; | |||
| default: | |||
| throw new IllegalArgumentException("image '" + imageUrl + "' should have one or two '/' characters"); | |||
| registry = slashTokens[0]; | |||
| user = slashTokens[1]; | |||
There was a problem hiding this comment.
This is different to what dosu says :) My understanding is aligned with dosu implementation.
IIUC dosu implementation #572 (comment) will bring this result
registry = mcr.microsoft.com
user = mssql/rhel
repoTag = server:2022-CU13-rhel-9.1
whereas your implementation will bring
registry = mcr.microsoft.com
user = mssql
repoTag = rhel/server:2022-CU13-rhel-9.1
There was a problem hiding this comment.
to me the latter makes more sense, though we are only bending image url (which can be almost anything) to what the class expects
There was a problem hiding this comment.
Yes, you was faster than me wanted to write user = mssql makes more sense to me now while thinking about it.
Dosu just implemented what I requested in issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure your PR meets the following requirements:
CI runs:
Without fix: https://url.corp.redhat.com/a7db151
With fix: https://url.corp.redhat.com/bbed950