Improve WP Admin UI #38
Conversation
westonruter
force-pushed
the
feature/wp-admin
branch
from
92cedf8
to
9317cf6
Compare
westonruter
force-pushed
the
feature/wp-admin
branch
from
9317cf6
to
083debb
Compare
| @@ -284,7 +289,7 @@ public function create_post_type() { | |||
| */ | |||
| function setup_metaboxes() { | |||
| $id = self::POST_TYPE; | |||
| $title = __( 'Data', 'customize-snapshots' ); | |||
| $title = __( 'Data', 'customize-snapshot' ); | |||
There was a problem hiding this comment.
The text domain is customize-snapshots
| if ( ! empty( $allcaps['edit_theme_options'] ) ) { | ||
| $allcaps['customize_publish'] = true; | ||
| } | ||
|
|
||
| // Grant all customize snapshot caps which weren't explicitly disallowed to users who can customize. |
There was a problem hiding this comment.
This is causing test failures.
There was a problem hiding this comment.
I restored the initial cap check in ab6ca42. Tests are passing now.
…omize snapshots We'll need a different mechanism to prevent mutating published (non-future) snapshots
| '<p><a href="%s" class="button button-secondary">%s</a></p>', | ||
| esc_url( $customize_url ), | ||
| esc_html__( 'Open in Customizer', 'customize-snapshots' ) | ||
| ); |
There was a problem hiding this comment.
This commit makes me happy 😄
|
@westonruter When you publish the snapshot all the settings disappear from the metabox |
|
Oh they are hidden after published. So we need to remove the checkbox toggle and hidden attribute for published snapshots so all the settings display |
|
@valendesigns I think the problem is that all of the settings get sent with |
…tely after saving a snapsot
…napshots into feature/wp-admin
…b#187 from branch bugfix/nested-phpunit-support2 xwp/wp-dev-lib@159119b...0f3058b
|
@valendesigns ok, ready for you to review. |
|
@westonruter I think we should hide the "Save Draft" button or change the customize button to "Edit" so it fits in the space. Thoughts? |
|
We also need to handle the publish button so the Snapshot updates the front-end. Otherwise scheduling will not work. |
|
@westonruter An issue with the updated state replacement JS is that the |
Actually, perhaps we should just hide the publish box entirely. This would be what #15 would implement, and at that time, the publish button could be restored. |
|
I think I know what to do. We can just remove the |
|
@valendesigns oh, and you know what? Now with b3ea60a it would be sweet if when a user lacks
|
|
So it makes the publish button say submit for review? |
|
@valendesigns yeah, try this: feature/wp-admin...feature/submit-for-review |
|
@valendesigns I merged |
No description provided.