Skip to content
This repository has been archived by the owner on Nov 10, 2022. It is now read-only.

Use phar for PHPCS 2.8.1 since builds are breaking in PHPCS 3.0.0 #234

Merged
merged 1 commit into from
May 4, 2017

Conversation

westonruter
Copy link
Contributor

The new 3.0.0 release of PHP_CodeSniffer has some back-compat problems as can be seen in these Travis build errors:

For the latter, see WordPress/WordPress-Coding-Standards#718

For a temporary fix, we can temporarily revert back to PHPCS 2.8.1.

@jrfnl
Copy link
Contributor

jrfnl commented May 4, 2017

Or maybe use PHPCS 2.9.0 which was released today ?

@kasparsd kasparsd deleted the fix/phpcs-3-compat branch May 4, 2017 04:51
@westonruter
Copy link
Contributor Author

@jrfnl is there a PHAR URL for that? I couldn't find it on the gh-pages branch.

@jrfnl
Copy link
Contributor

jrfnl commented May 4, 2017

@westonruter Just checked, but looks like the phar for 2.9.0 never made it into the gh-pages branch.
You could of course do a git clone of the 2.9-dev branch with depth=1 instead.

@jrfnl
Copy link
Contributor

jrfnl commented May 7, 2017

@westonruter Turns out there apparently is a phar, see: https://github.com/squizlabs/PHP_CodeSniffer/releases/tag/2.9.0
Direct link: https://github.com/squizlabs/PHP_CodeSniffer/releases/download/2.9.0/phpcs.phar

@kasparsd
Copy link
Contributor

kasparsd commented May 8, 2017

Thanks @jrfnl! I just created a new pull request #235.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants