Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hash argument for uploadFile() #39

Merged
merged 2 commits into from
Dec 5, 2017
Merged

Hash argument for uploadFile() #39

merged 2 commits into from
Dec 5, 2017

Conversation

jamiesyme
Copy link
Contributor

As discussed in #32, this potentially allows the library to be used with streams.

Ideally, we'd check if data is a stream before defaulting to sha1(), but this is a start.

@yakovkhalinsky
Copy link
Owner

Very nice, would be interested in some feedback once this is in npm

@yakovkhalinsky yakovkhalinsky added this to the 1.0.4 release milestone Dec 5, 2017
@yakovkhalinsky yakovkhalinsky merged commit debc9d2 into yakovkhalinsky:master Dec 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.0.4 release
Development

Successfully merging this pull request may close these issues.
2 participants
@jamiesyme @yakovkhalinsky