Add shellcheck target and CI workflow

.github/workflows/test.yaml

@@ -13,3 +13,10 @@ jobs:
     - uses: actions/checkout@v2
     - run: make test
     # - uses: mxschmitt/action-tmate@v3
+
+  style:
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v2
+    - run: make style-check

Makefile

@@ -49,6 +49,9 @@ test:
 	make gh-pages
 	make clean
 
+style-check:
+	file --mime-type bin/* | grep text/x-shellscript | cut -d: -f1 | xargs shellcheck
+
 add-new:
 	for f in new/*; do cp "$$f" "src/$${f#*-}"; done
 

bin/new-test-file

@@ -37,6 +37,7 @@ main() (
 )
 
 template() (
+  # shellcheck disable=SC1039
   cat <<...
 ---
 - name: <test title>

bin/new-test-id

@@ -3,8 +3,7 @@
 (
   while true; do
     id=$(
-      cat /dev/urandom |
-      LC_ALL=C tr -cd A-HJ-NP-Z2-9 |
+      LC_ALL=C tr -cd A-HJ-NP-Z2-9 < /dev/urandom |
       fold -w4 |
       grep '[A-Z]' |
       grep '[0-9]' |

bin/run-all-parsers

@@ -8,14 +8,16 @@
 # It is used to run every test in the suite against each YAML parser.
 #
 #------------------------------------------------------------------------------
+# shellcheck disable=SC2030
+# shellcheck disable=SC2031
 
 set -e -u -o pipefail
 
 main() (
   id=$ID
   tmp=/tmp/test/$id
 
-  set -- $RUNNERS
+  set -- "$RUNNERS"
 
   run-all-parsers "$@"
 

bin/tsv-to-new

@@ -54,7 +54,7 @@ for line in "${each[@]}"; do
     shift
   done
 
-  if [[ $group && $group == $_group ]]; then
+  if [[ $group && $group == "$_group" ]]; then
     more=1
   else
     more=''