Fixes the virtual link type #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Virtual links were created as
diron Windows even where they were pointing towards files, which was breaking installs. We didn't notice it before because:Our repository happens to contain the right type of symlinks (probably created before the regression), and the case didn't happen organically.
For some reason Azure didn't catch the error, but running the tests locally did. Since I always run the tests on Azure only when working on Windows, I didn't notice it before.
A followup would be to refactor
NodeFS.symlinkPromiseto stop using this trailing-slash heuristic, and instead use thetypeparameter (I think we would just have to move this trailing-slash thing in the few places that actually need it, such as theRawLinkFetcher).