Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements read/write #374

Merged
merged 2 commits into from
Aug 22, 2019
Merged

Implements read/write #374

merged 2 commits into from
Aug 22, 2019

Conversation

arcanis
Copy link
Member

@arcanis arcanis commented Aug 22, 2019

What's the problem this PR addresses?

Our FS layer doesn't implement read and write, which causes issues with some packages. One particular case is cp-file, which uses graceful-fs, which overrides our own createReadStream override with its own that simply returns new ReadStream, which has a regular open/read/close workflow.

How did you fix it?

  • I've implemented read and write in FakeFS.
  • In order to disambiguate whether a fd comes from the real filesystem or a zip one, the zip fds will have a special bit set (0x80000000). This bit would cause Node to reject the fd in other cases.

Which packages would need a new release (if any)?

berry-fslib / berry-cli / berry-pnp / berry-pnpify

Have you run yarn version [major|minor|patch] --deferred in those packages?

  • Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant