Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to fix SourceForge bug report # 119 #16

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Changes to fix SourceForge bug report # 119 #16

wants to merge 2 commits into from

Conversation

MKhFisher
Copy link

Calculates broker fees as a minimum value with percentage of total until maximum value is reached.

MKhFisher and others added 2 commits May 18, 2014 18:52
Fixes for Bug Report #199 on SourceForge. Also includes jUnit test
cases.
@yccheok
Copy link
Owner

yccheok commented May 22, 2014

Thanks for the contribution on solving reported bug.

https://sourceforge.net/p/jstock/bugs/119/

Honestly, I don't understand the bug being reported.

Can you explain the reported bug, along with how your submitted code patch can solve the problem?

Thank you very much!

@MKhFisher
Copy link
Author

What I've found is most brokers in the US charge on the basis of a minimum
flat rate (let's assume $20) per trade and then a percentage of the total
trade on top of that (let's assume 4%) up until a maximum fee (let's assume
$2000).

If someone purchases 100 shares at $10, then the broker would charge $20
(minimum) + $40 (percentage fee).
If someone purchases 100,000 shares at $10, then the broker would charge
$2000 because the percentage fee would be greater than the maximum allowed.

Please let me know if that clears things up more.

On Thu, May 22, 2014 at 9:23 AM, Yan Cheng Cheok
notifications@gitpro.ttaallkk.topwrote:

Thanks for the contribution on solving reported bug.

https://sourceforge.net/p/jstock/bugs/119/

Honestly, I don't understand the bug being reported.

Can you explain the reported bug, along with how your submitted code patch
can solve the problem?

Thank you very much!


Reply to this email directly or view it on GitHubhttps://github.com//pull/16#issuecomment-43910976
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants