Additional indicators #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 4, 2014 15:48
…yAuthOption in org.yccheok.jstock.engine.Utils.
|
Just received your pull request. Will come back to you probably by next week, as I'm pretty tied up, with Yahoo! Finance to Google Finance migration right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to use additional indicators, f.e. book value or dividend data, for alarms.
Could you please review the extension and give me feedback?
Is the way to add the feature OK?
If not, what to change?
If yes, I would like to add some other indicators and contribute the changes to the project.
Is it enough to extend only the Yahoo data source?